Skip to content

Extending execution context for retries #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2021
Merged

Extending execution context for retries #362

merged 4 commits into from
Feb 19, 2021

Conversation

alrod
Copy link
Member

@alrod alrod commented Jan 20, 2021 •
edited
Loading

resolves #373

@alrod alrod requested a review from mhoeger February 5, 2021 21:49
@alrod alrod mentioned this pull request Feb 5, 2021
Merged
7 tasks
mhoeger
mhoeger reviewed Feb 5, 2021
View reviewed changes
mhoeger
mhoeger reviewed Feb 5, 2021
View reviewed changes
mhoeger
mhoeger reviewed Feb 5, 2021
View reviewed changes
mhoeger
mhoeger reviewed Feb 5, 2021
View reviewed changes
Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, mostly looks good!!

@alrod alrod requested a review from mhoeger February 9, 2021 01:02
mhoeger
mhoeger approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@mhoeger mhoeger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes and for the interface comments!!

Before merging this PR though, could you please merge this one: Azure/azure-functions-language-worker-protobuf#53 (review)
And then pull updates from azure-functions-language-worker-protobuf to this repo following these steps? These steps make sure that proto files don't get out of sync between workers.

Will approve again if that change dismisses that review!

@alrod
Copy link
Member Author

alrod commented Feb 13, 2021 •
edited
Loading

LGTM! Thanks for the changes and for the interface comments!!

Before merging this PR though, could you please merge this one: Azure/azure-functions-language-worker-protobuf#53 (review)
And then pull updates from azure-functions-language-worker-protobuf to this repo following these steps? These steps make sure that proto files don't get out of sync between workers.

Will approve again if that change dismisses that review!

  1. I updated the prorofile from protobuf repository.
  2. Also I added new Exception interface for retry context. (it is the same to IRpcException)
    @mhoeger, please review once again.

@alrod alrod requested a review from mhoeger February 13, 2021 01:54
mhoeger
mhoeger approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@mhoeger mhoeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!✅

@alrod alrod merged commit 1e72e6b into v2.x Feb 19, 2021
@ejizba ejizba deleted the alrod/retryCount branch May 29, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoeger mhoeger mhoeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for RetryContext
2 participants
@alrod @mhoeger