Adding retry context properties to InvocationRequest #7134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
Feb 12, 2021
| @@ -26,6 +28,25 @@ public static async Task<InvocationRequest> ToRpcInvocationRequest(this ScriptIn | |||
| TraceContext = GetRpcTraceContext(context.Traceparent, context.Tracestate, context.Attributes, logger), | |||
| }; | |||
|
|
|||
| if (context.ExecutionContext.RetryContext != null) | |||
There was a problem hiding this comment.
Move this to static method to make it easier to add unit test
pragnagopa
reviewed
Feb 12, 2021
There was a problem hiding this comment.
Added small comment.
FYI @brettsam @ankitkumarr for dotnet worker
pragnagopa
previously approved these changes
Feb 13, 2021
alrod
force-pushed
the
alrod/rpcretry
branch
from
02f85d6 to
762c88a
Compare
pragnagopa
approved these changes
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #7048
Pull request checklist
release_notes.mdAdditional information
proto: Azure/azure-functions-language-worker-protobuf#53
nodejs worker: Azure/azure-functions-nodejs-worker#362