Skip to content

Add support to reload environment variables #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2018
Merged

Add support to reload environment variables #20

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3777469
Add support to load current process environment variables
pragnagopa Nov 17, 2018
72f4fca
Fix errors
pragnagopa Nov 27, 2018
258c22b
addressing CR
pragnagopa Nov 30, 2018
84fa185
fixing message names
pragnagopa Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/proto/FunctionRpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ message StreamingMessage {

// Worker logs a message back to the host
RpcLog rpc_log = 2;

FunctionEnvironmentReLoadRequest function_environment_reload_request = 25;

FunctionEnvironmentReLoadResponse function_environment_reload_response = 26;
}
}

Expand Down Expand Up @@ -180,6 +184,16 @@ message WorkerStatusRequest{
message WorkerStatusResponse {
}

message FunctionEnvironmentReLoadRequest {
// Environment variables from the current process
map<string, string> environment_variables = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can an environment variable's value ever be null or empty? languages like javascript will buffer overflow if so :|

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can control this in host.

}

message FunctionEnvironmentReLoadResponse {
// Status of the response
StatusResult result = 3;
}

// Host tells the worker to load a Function
message FunctionLoadRequest {
// unique function identifier (avoid name collisions, facilitate reload case)
Expand Down