Add support to reload environment variables #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pragnagopa - could you add some context for this PR in the description? |
mhoeger
reviewed
Nov 28, 2018
| @@ -180,6 +184,16 @@ message WorkerStatusRequest{ | |||
| message WorkerStatusResponse { | |||
| } | |||
|
|
|||
| message FunctionEnvironmentLoadRequest { | |||
| // Environment variables from the current process | |||
| map<string, string> environment_variables = 1; | |||
There was a problem hiding this comment.
Can an environment variable's value ever be null or empty? languages like javascript will buffer overflow if so :|
There was a problem hiding this comment.
we can control this in host.
mhoeger
reviewed
Nov 29, 2018
src/proto/FunctionRpc.proto
Outdated
| @@ -65,6 +65,10 @@ message StreamingMessage { | |||
|
|
|||
| // Worker logs a message back to the host | |||
| RpcLog rpc_log = 2; | |||
|
|
|||
| FunctionEnvironmentLoadRequest function_environment_load_request = 25; | |||
There was a problem hiding this comment.
Can we call it something like "FunctionEnvironmentReloadRequest", since environment variables will be there by default for most cases?
There was a problem hiding this comment.
makes sense. will update
mhoeger
reviewed
Nov 30, 2018
src/proto/FunctionRpc.proto
Outdated
| @@ -180,6 +184,16 @@ message WorkerStatusRequest{ | |||
| message WorkerStatusResponse { | |||
| } | |||
|
|
|||
| message FunctionEnvironmentLoadRequest { | |||
There was a problem hiding this comment.
I think you might have missed renaming the message names!
mhoeger
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new message to support reloading of environment variables. This message is specifically used during specialization when functions runtime starts a language worker in place holder mode and then assigns to an app at a later point in time.