Repository navigation
deps: migrate go-vcr.v4 to v4.0.7 - #10613
Open
Victor Vazquez (vhvb1989) wants to merge 1 commit into
Open
Victor Vazquez (vhvb1989) wants to merge 1 commit into
Victor Vazquez (vhvb1989) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2092c44-0278-465f-aa49-ebd550f62710
Victor Vazquez (vhvb1989)
requested review from
JeffreyCA,
Rick Winter (RickWinter),
hemarina,
Richard Park (richardpark-msft) and
tg-msft
as code owners
October 19, 2026 22:15
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 23 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Newly recorded cassettes can retain SAS signatures in request form data despite URL sanitization.
1 open issue
What changed in this PR
Migrates azd’s recording infrastructure to go-vcr v4.0.7, addressing #10612 separately from the dependency-only updates in #10572.
Changes:
- Updates cassette and recorder imports to v4’s package layout.
- Replaces recorder setters with constructor options while retaining legacy method/URL matching.
- Updates core dependency requirements and checksums.
| File | Description |
|---|---|
| cli/azd/test/recording/trim_response.go | Updates cassette import. |
| cli/azd/test/recording/sanitize.go | Updates sanitizer cassette import. |
| cli/azd/test/recording/sanitize_test.go | Updates sanitizer test import. |
| cli/azd/test/recording/recording.go | Migrates recorder initialization and preserves matching. |
| cli/azd/test/recording/proxy.go | Updates recorder import. |
| cli/azd/test/recording/poll_discard.go | Updates polling cassette import. |
| cli/azd/test/recording/poll_discard_test.go | Updates polling test import. |
| cli/azd/test/recording/func_publish_poller.go | Updates publish-poller cassette import. |
| cli/azd/test/recording/func_publish_poller_test.go | Updates publish-poller test import. |
| cli/azd/test/cmdrecord/proxy/main.go | Updates command-proxy recorder import. |
| cli/azd/test/cmdrecord/cmdrecorder.go | Updates command-recorder import. |
| cli/azd/test/cmdrecord/cmdrecorder_test.go | Updates command-recorder test import. |
| cli/azd/go.sum | Refreshes dependency checksums. |
| cli/azd/go.mod | Pins go-vcr v4.0.7 and its YAML dependency. |
Review effort: Balanced
|
|
||
| // Sanitize | ||
| vcr.AddHook(func(i *cassette.Interaction) error { | ||
| recorderOptions = append(recorderOptions, recorder.WithHook(func(i *cassette.Interaction) error { |
Contributor
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10612.
Migrate
gopkg.in/dnaeon/go-vcr.v3togopkg.in/dnaeon/go-vcr.v4@v4.0.7in source and module requirements. This is separate from the source-change-free dependency updates in #10572.pkglayout and replace removed recorder setters with functional constructor options.Validation
go build -mod=readonly ./...passes in core and all 18 Go extension modules.go tool mage checkDependencyVersionspasses.go test -mod=readonly ./... -shortpasses in these source-affected modules:cli/azdgit diff --checkpasses.