Repository navigation
deps: migrate glamour to v2.0.1 - #10608
Victor Vazquez (vhvb1989) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a2092c44-0278-465f-aa49-ebd550f62710
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
|
Azure Pipelines: Successfully started running 2 pipeline(s). 23 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused migration preserves rendering behavior, adds regression coverage, and has no unresolved blocking findings.
No open issues 🎉
What changed in this PR
Migrates azd’s Markdown renderer to charm.land/glamour/v2@v2.0.1, addressing #10607 separately from the dependency-only updates in #10572.
Changes:
- Replaces automatic styling with explicit non-terminal, light, and dark styles.
- Preserves dynamic wrapping and fallback behavior.
- Updates dependencies and strengthens non-terminal output regression coverage.
| File | Description |
|---|---|
cli/azd/pkg/output/colors.go |
Migrates imports and selects styles explicitly. |
cli/azd/pkg/output/colors_test.go |
Rejects ANSI escapes in non-terminal output. |
cli/azd/go.sum |
Updates dependency checksums. |
cli/azd/go.mod |
Requires Glamour v2 and updates related dependencies. |
cli/azd/.vscode/cspell.yaml |
Allows termenv in the renderer source. |
Review effort: Balanced
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
Summary
Fixes #10607.
Migrate
github.com/charmbracelet/glamourtocharm.land/glamour/v2@v2.0.1in source and module requirements. This is separate from the source-change-free dependency updates in #10572.charm.land/glamour/v2module.WithAutoStylewith explicit no-TTY/light/dark style selection using the original terminal/background heuristics.Validation
go build -mod=readonly ./...passes in core and all 18 Go extension modules.go tool mage checkDependencyVersionspasses.go test -mod=readonly ./... -shortpasses in these source-affected modules:cli/azdgit diff --checkpasses.