Skip to content

deps: migrate armdeploymentstacks to v2.0.0 - #10606

Open
Victor Vazquez (vhvb1989) wants to merge 2 commits into
mainfrom
deps/deployment-stacks-v2-0-0
Open

Victor Vazquez (vhvb1989) wants to merge 2 commits into
mainfrom
deps/deployment-stacks-v2-0-0

Conversation

@vhvb1989

@vhvb1989 Victor Vazquez (vhvb1989) commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

Summary

Fixes #10605.

Migrate github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armdeploymentstacks to github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armdeploymentstacks/v2@v2.0.0 in source and module requirements. This is separate from the source-change-free dependency updates in #10572.

  • Migrate deployment stack clients and models to v2 across production, fixtures, and tests.
  • Replace the removed shared delete/detach enum with the SDK's management-group, resource-group, and resource-specific action enums.
  • Preserve existing delete defaults and configured detach behavior. Add a serialized-default regression and update Bicep-to-SDK round-trip assertions for all three scopes.
  • Full core short suite and affected-package lint pass.
  • Tidy every source-affected module and align shared direct dependencies selected by MVS.
  • Remove only policy exceptions made obsolete by this migration.
  • Preserve existing behavior and use published SDK versions without local replacements.

Validation

  • go build -mod=readonly ./... passes in core and all 18 Go extension modules.

  • go tool mage checkDependencyVersions passes.

  • go test -mod=readonly ./... -short passes in these source-affected modules:

    • cli/azd

git diff --check passes.

Functional compatibility follow-up

Migrated only Deployment Stacks request URL API versions to 2025-07-01, retaining response bodies and strict request matching. Offline functional playback passes for both resource-group and subscription scope provisioning/deletion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a2092c44-0278-465f-aa49-ebd550f62710
@github-actions

Copy link
Copy Markdown

📋 Prioritization Note

Thanks for the contribution! The linked issue isn't in the current milestone yet.
Thank you for logging this issue; our team is reviewing it. If you need urgent prioritization, tag Rick Winter (@RickWinter) and Kristen Womack (@kristenwomack) to let us know.

@github-actions github-actions Bot added ext-finetune azure.ai.finetune extension ext-models azure.ai.models extension ext-projects azure.ai.projects extension ext-rle azure.ai.rle extension ext-routines azure.ai.routines extension ext-skills azure.ai.skills extension ext-toolboxes azure.ai.toolboxes extension ext-appservice azure.appservice extension ext-coding-agent azure.coding-agent extension ext-foundry azure.ai.{agents,connections,inspector,projects,routines,skills,toolboxes}, microsoft.foundry ext-training azure.ai.training extension labels Oct 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both deployment-stack functional cassettes retain the old API version and cannot match v2 requests during playback.

1 open issue
What changed in this PR

Migrates azd’s Deployment Stacks integration to SDK v2.0.0 for #10605, separately from the dependency-only updates in #10572.

Changes:

  • Updates SDK imports and scope-specific action enums while preserving delete/detach settings.
  • Adds serialized-default coverage and updates round-trip assertions.
  • Aligns shared dependencies across affected extensions and removes obsolete exceptions.
File Description
cli/​azd/​pkg/​infra/​provisioning/​bicep/​deployment_stacks_test.go Updates v2 round-trip assertions.
cli/​azd/​pkg/​azapi/​stack_deployments.go Migrates SDK and default action enums.
cli/​azd/​pkg/​azapi/​stack_deployments_test.go Tests serialized defaults and v2 overrides.
cli/​azd/​pkg/​azapi/​deployments_unit_test.go Uses v2 SDK models.
cli/​azd/​go.sum Updates core dependency checksums.
cli/​azd/​go.mod Requires v2 and related dependency upgrades.
cli/​azd/​extensions/​azure.coding-agent/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.coding-agent/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.appservice/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.appservice/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.training/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.training/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.toolboxes/​go.sum Refreshes SDK and tidy checksums.
cli/​azd/​extensions/​azure.ai.toolboxes/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.skills/​go.sum Refreshes SDK and tidy checksums.
cli/​azd/​extensions/​azure.ai.skills/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.routines/​go.sum Refreshes SDK and tidy checksums.
cli/​azd/​extensions/​azure.ai.routines/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.rle/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.rle/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.projects/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.projects/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.models/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.models/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.finetune/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.finetune/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.evaluations/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.evaluations/​go.mod Aligns SDK dependencies; marks YAML direct.
cli/​azd/​extensions/​azure.ai.dataset/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.dataset/​go.mod Aligns SDK dependencies.
cli/​azd/​extensions/​azure.ai.connections/​go.sum Refreshes SDK checksums.
cli/​azd/​extensions/​azure.ai.connections/​go.mod Aligns SDK dependencies.
cli/​azd/​dependency-versions.json Removes resolved azcore exceptions.

Review effort: Balanced

Comment thread cli/azd/go.mod
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/operationalinsights/armoperationalinsights/v2 v2.0.2
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resourcegraph/armresourcegraph v0.9.0
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armdeploymentstacks v1.0.1
github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/resources/armdeploymentstacks/v2 v2.0.0
Replay resource-group and subscription scope provisioning/deletion without changing response fixtures or request matching.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a2092c44-0278-465f-aa49-ebd550f62710
Copilot AI balanced review requested due to automatic review settings October 19, 2026 23:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review found no blocking issues in the focused migration, regression coverage, or dependency alignment.

1 open issue

Review effort: Balanced

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.connections PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-connections.zip"
  • Version: 1.0.0-beta.10.pr.10606.6976033
  • Merge commit: bc32be0

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.appservice PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-appservice.zip"
  • Version: 0.1.1-pr.10606.6976416
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.coding-agent PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-coding-agent.zip"
  • Version: 0.6.1-pr.10606.6976413
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.projects PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-projects.zip"
  • Version: 1.0.0-beta.14.pr.10606.6976418
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.finetune PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-finetune.zip"
  • Version: 0.0.17-preview.pr.10606.6976414
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.models PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-models.zip"
  • Version: 0.0.7-preview.pr.10606.6976415
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.skills PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-skills.zip"
  • Version: 1.0.0-beta.8.pr.10606.6976420
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.routines PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-routines.zip"
  • Version: 1.0.0-beta.10.pr.10606.6976419
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.toolboxes PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-toolboxes.zip"
  • Version: 1.0.0-beta.11.pr.10606.6976421
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.dataset PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-dataset.zip"
  • Version: 1.0.0-beta.2.pr.10606.6976432
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.rle PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-rle.zip"
  • Version: 0.4.0-preview.pr.10606.6976427
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.training PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-training.zip"
  • Version: 0.0.3-preview.pr.10606.6976422
  • Merge commit: 4f3a397

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

azure.ai.evaluations PR build

Note

This is an unsigned development build. Install it only if you trust this PR.

Install the extension:

azd ext install "https://azuresdkartifacts.z5.web.core.windows.net/azd/extensions/pr/10606/azure-ai-evaluations.zip"
  • Version: 1.0.0-beta.2.pr.10606.6976429
  • Merge commit: 4f3a397

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext-appservice azure.appservice extension ext-coding-agent azure.coding-agent extension ext-connections azure.ai.connections extension ext-dataset azure.ai.dataset extension ext-evals azure.ai.evaluations extension ext-finetune azure.ai.finetune extension ext-foundry azure.ai.{agents,connections,inspector,projects,routines,skills,toolboxes}, microsoft.foundry ext-models azure.ai.models extension ext-projects azure.ai.projects extension ext-rle azure.ai.rle extension ext-routines azure.ai.routines extension ext-skills azure.ai.skills extension ext-toolboxes azure.ai.toolboxes extension ext-training azure.ai.training extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deps: migrate armdeploymentstacks to v2.0.0

2 participants