Skip to content

Buffer writes to block size #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2019
Merged

Buffer writes to block size #303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc0cbc3
Buffer writes
akharit Oct 18, 2019
95f1eef
Run on python 3.7
akharit Oct 18, 2019
82590b0
Update version
akharit Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ matrix:
- python: 3.4
- python: 3.5
- python: 3.6
- python: 3.7

install:
# Install dependencies
Expand Down Expand Up @@ -39,5 +40,5 @@ deploy:
distributions: "bdist_wheel sdist" # Parameter order for distributions is important.
on:
tags: true
python: '3.6'
python: '3.7'
repo: Azure/azure-data-lake-store-python
5 changes: 5 additions & 0 deletions HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
Release History
===============

0.0.48 (2019-10-18)
+++++++++++++++++++
* Buffer writes to prevent out of memory problems
* Add Python 3.7 in travis configuration

0.0.47 (2019-08-14)
+++++++++++++++++++
* Remove logging of bearer token
Expand Down
126 changes: 25 additions & 101 deletions Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,55 +124,6 @@ ADLDownloader(adl, '', 'my_temp_dir', 5, 2**24)
```
# API

|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|

#### class azure.datalake.store.core.AzureDLFileSystem(token=None, per_call_timeout_seconds=60, \*\*kwargs)
Access Azure DataLake Store as if it were a file-system

Expand Down Expand Up @@ -211,46 +162,26 @@ Access Azure DataLake Store as if it were a file-system

### Methods

|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|




















<!-- !! processed by numpydoc !! -->

#### access(self, path, invalidate_cache=True)
Expand Down Expand Up @@ -1235,12 +1166,8 @@ of files or a glob pattern.

### Methods

|
|
|
|
|
|


<!-- !! processed by numpydoc !! -->

#### active(self)
Expand Down Expand Up @@ -1397,12 +1324,9 @@ of files or a glob pattern.

### Methods

|
|
|
|
|
|



<!-- !! processed by numpydoc !! -->

#### active(self)
Expand Down
2 changes: 1 addition & 1 deletion azure/datalake/store/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# license information.
# --------------------------------------------------------------------------

__version__ = "0.0.47"
__version__ = "0.0.48"

from .core import AzureDLFileSystem
from .multithread import ADLDownloader
Expand Down
13 changes: 9 additions & 4 deletions azure/datalake/store/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1213,10 +1213,15 @@ def write(self, data):
if self.closed:
raise ValueError('I/O operation on closed file.')

out = self.buffer.write(ensure_writable(data))
self.loc += out
self.flush(syncFlag='DATA')
return out
# TODO Flush may be simplified
# Buffered writes so a very large buffer is not copied leading to very large memory consumption
bytes_written = 0
for i in range(0, len(data), self.blocksize):
out = self.buffer.write(ensure_writable(data[i:i + self.blocksize]))
self.loc += out
bytes_written += out
self.flush(syncFlag='DATA')
return bytes_written

def flush(self, syncFlag='METADATA', force=False):
"""
Expand Down