Skip to content

Conversation

@akharit
Copy link
Member

@akharit akharit commented Oct 18, 2019


This checklist is used to make sure that common guidelines for a pull request are followed.

Description of the change

Write was copying all data given to it. This can cause memory issues if the data to be written is large enough. Buffered the writes to block size.

General Guidelines

  • The PR has modified HISTORY.rst with an appropriate description of the change and a version increment.
  • The PR has supporting test coverage that confirm the expected behavior and protects against regressions, including necessary recordings.
  • Links to associated bugs, if any, are in the description.

@coveralls
Copy link

coveralls commented Oct 18, 2019

Coverage Status

Coverage increased (+1.08%) to 86.281% when pulling 82590b0 on akharit-write-buffer into 339b176 on dev.

@akharit akharit merged commit dc4716d into dev Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants