Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-Pick Appinsights: Adds classic attribute back to cosmos db to support appinsights sdk (#4781) (#4799) #4804

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Cherry-Pick Appinsights: Adds classic attribute back to cosmos db to support appinsights sdk (#4781) (#4799) #4804

merged 2 commits into from
Oct 15, 2024

Commits on Oct 15, 2024

  1. Cherry-Pick Appinsights: Adds classic attribute back to cosmos db to … 

    …support appinsights sdk (#4781) (#4799)

## Description

As part of this PR, adding back attributes required by appinsights sdk.
It broke the customer experience with appinsight as Appinsight SDK
supports very specific set of attributes.

This implementation will change in future release, where open telemetry
attributes will be controlled by Env Variable as mentioned here.


https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-spans.md#semantic-conventions-for-database-client-calls

**4.42.3**


![image](https://github.com/user-attachments/assets/6c19eab0-4884-4648-b6d9-c941d58e8e0b)

**v4.43.0**


![image](https://github.com/user-attachments/assets/fd2a70b4-ed37-4618-b1a5-f654587bf6ab)

**v4.43.1**


![image](https://github.com/user-attachments/assets/5bbe54ec-34f3-4538-a7b4-abff1b1853ea)

After this PR:


![image](https://github.com/user-attachments/assets/2ea64a34-4e57-4dec-a29e-32ffcd77919a)

After this change, customer has to set `OTEL_SEMCONV_STABILITY_OPT_IN`
to `database/dup`, in order to see the otel (new and old) attributes.
otherwise SDK will emit only classic attributes which would be
compatible with appinsights sdk also.

## Type of change
- [] Bug fix (non-breaking change which fixes an issue)
    @sourabh1007
    sourabh1007 committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a123641 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'releases/3.45.0-preview.1' into users/sourabhjain/appin… 

    …sightprcherrypick
    @kirankumarkolli
    kirankumarkolli authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2691d51 View commit details
    Browse the repository at this point in the history