Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix batch ai cluster auto storage account creation issue #7132

Merged
merged 4 commits into from
Aug 24, 2018
Merged

Fix batch ai cluster auto storage account creation issue #7132

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7c2aba
Fix batch ai cluster auto storage account creation issue
llidev Aug 23, 2018
e8f4553
bump up Batch AI version
llidev Aug 23, 2018
d543767
Update Batch AI History.rst
llidev Aug 23, 2018
6d20613
Update Batch AI Release History with more detail fix information
llidev Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/command_modules/azure-cli-batchai/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
Release History
===============

0.4.3
+++++
* Minor fixes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should call out that it fixes the bug since that's a customer-facing change (anyone who's run into that will want to know it's fixed).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved


0.4.2
+++++
* Minor fixes
Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-batchai/azure/cli/command_modules/batchai/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ def _create_auto_storage_account(storage_client, resource_group, location):
name = _generate_auto_storage_account_name()
check = storage_client.storage_accounts.check_name_availability(name).name_available
storage_client.storage_accounts.create(resource_group, name, {
'sku': Sku(SkuName.standard_lrs),
'sku': Sku(name=SkuName.standard_lrs),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check if 549 and 551 should be changed as well - i suppose the storage sdk switched to named parameters everywhere

'kind': Kind.storage,
'location': location}).result()
return name
Expand Down
2 changes: 1 addition & 1 deletion src/command_modules/azure-cli-batchai/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
logger.warn("Wheel is not available, disabling bdist_wheel hook")
cmdclass = {}

VERSION = "0.4.2"
VERSION = "0.4.3"
# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
CLASSIFIERS = [
Expand Down