Fix batch ai cluster auto storage account creation issue #7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
approved these changes
Aug 23, 2018
|
Fixes #7129. |
tjprescott
suggested changes
Aug 23, 2018
| @@ -3,6 +3,10 @@ | |||
| Release History | |||
| =============== | |||
|
|
|||
| 0.4.3 | |||
| +++++ | |||
| * Minor fixes | |||
There was a problem hiding this comment.
This should call out that it fixes the bug since that's a customer-facing change (anyone who's run into that will want to know it's fixed).
|
hi, we have test_batchai_cluster_with_auto_storage unit test which is supposed to cover this logic. Do we still run live tests nightly? |
|
Please fix the following lines as well (if storage switched to named parameters in one place, most probably it switched in other places as well): |
| @@ -575,7 +575,7 @@ def _create_auto_storage_account(storage_client, resource_group, location): | |||
| name = _generate_auto_storage_account_name() | |||
| check = storage_client.storage_accounts.check_name_availability(name).name_available | |||
| storage_client.storage_accounts.create(resource_group, name, { | |||
| 'sku': Sku(SkuName.standard_lrs), | |||
| 'sku': Sku(name=SkuName.standard_lrs), | |||
There was a problem hiding this comment.
please check if 549 and 551 should be changed as well - i suppose the storage sdk switched to named parameters everywhere
tjprescott
approved these changes
Aug 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix batch ai cluster auto storage account creation issue
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.