Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two issues in storage module. #5168

Merged
merged 3 commits into from
Dec 26, 2017
Merged

Fix two issues in storage module. #5168

merged 3 commits into from
Dec 26, 2017

Conversation

troydai
Copy link
Contributor

@troydai troydai commented Dec 23, 2017 •
edited
Loading

  1. Command register failed in older profile which is because the module tries to register common data plane arguments to a command which is not added.
  2. Fix the URL encoding issue for file and blob copy.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

Command Guidelines

  • Each command and parameter has a meaningful description.
  • Each new command has a test.

(see Authoring Command Modules)

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5168
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

@tjprescott tjprescott merged commit 996a1f4 into Azure:KnackFinal_2.0.24 Dec 26, 2017
tjprescott added a commit that referenced this pull request Dec 27, 2017
@tjprescott
Finalize Knack Branch. Re-enable all Tests. (#5140)
4d70528 
* Sync Knack branc with dev

* Convert failing live tests to LiveScenarioTests.

* Convert flaky Batch test to LiveScenarioTest.

* Rerun tests and disable flaky tests.

* Add script to scrub CI log for test failures.

* Test re-recordings.

* Reduce batch module load time

* Work on --force option for vault delete and backup commands...

* Reduce Keyvault module load time (#5154)

* Re-enable more tests.

* Removed location from vnet test (#5153)

* Re-enable more tests.

* Fix up tests for network, vm, and monitor.

* Fix webapp tests.

* Bump appservice version

* More test fixes.

* Fix pylint.

* Fix two issues in storage module. (#5168)

* Fix storage module issue for older profile

* Fix storage URL encoding issue under Python 2.7

* Run pylint on all modules altogether

* Re-record tests.

* Re-record tests.

* Re-record tests.

* Fix DLA recording processor test issue.
@troydai troydai deleted the kstore branch January 17, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjprescott tjprescott tjprescott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@troydai @azuresdkci @tjprescott