Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Keyvault module load time #5154

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Improve Keyvault module load time #5154

merged 1 commit into from
Dec 21, 2017

Conversation

troydai
Copy link
Contributor

@troydai troydai commented Dec 21, 2017

Similar to the fix in the batch module, delay load the operation handler.

Reduce load time from 0.9s to 0.03s

@azuresdkci
Copy link
Contributor

View a preview at https://prompt.ws/r/Azure/azure-cli/5154
This is an experimental preview for @microsoft.com users.
(It may take a minute or two for your instance to be ready)
Email feedback to 'azfeedback' with subject 'Prompt Feedback'.

Copy link
Member

@tjprescott tjprescott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @troydai !

@tjprescott tjprescott merged commit c1e7f95 into Azure:KnackFinal_2.0.24 Dec 21, 2017
@troydai troydai deleted the kperf-kv branch December 21, 2017 22:29
tjprescott added a commit that referenced this pull request Dec 27, 2017
* Sync Knack branc with dev

* Convert failing live tests to LiveScenarioTests.

* Convert flaky Batch test to LiveScenarioTest.

* Rerun tests and disable flaky tests.

* Add script to scrub CI log for test failures.

* Test re-recordings.

* Reduce batch module load time

* Work on --force option for vault delete and backup commands...

* Reduce Keyvault module load time (#5154)

* Re-enable more tests.

* Removed location from vnet test (#5153)

* Re-enable more tests.

* Fix up tests for network, vm, and monitor.

* Fix webapp tests.

* Bump appservice version

* More test fixes.

* Fix pylint.

* Fix two issues in storage module. (#5168)

* Fix storage module issue for older profile

* Fix storage URL encoding issue under Python 2.7

* Run pylint on all modules altogether

* Re-record tests.

* Re-record tests.

* Re-record tests.

* Fix DLA recording processor test issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants