Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Service] Backport Breaking Change: Redact appsettings, storage-account, configs #28671

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

amberwang113
Copy link
Contributor

@amberwang113 amberwang113 commented Apr 1, 2024

Related command
az webapp config appsettings set/delete
az logicapp config appsettings set/delete
az functionapp config appsettings set/delete
az staticwebapp appsettings set/delete
az webapp config connection-string set/delete
az webapp config storage-account add/update/delete

Description
Backport fixes from #27565 and #27629 for issue #28631

Testing Guide

History Notes

[App Service] [BREAKING CHANGE] Redact appsettings output on set/delete commands
[App Service] [BREAKING CHANGE] az webapp config: Redact webapp config connection-string and storage-account values


This checklist is used to make sure that common guidelines for a pull request are followed.

Copy link

Hi @amberwang113,
Usually we only allow pull requests to be submitted to the dev branch, please double check your pull request target branch 2.38.

Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 2, 2024

AppService

@amberwang113 amberwang113 changed the title [AppService] BREAKING CHANGE: Redact appsettings, storage-account, configs [AppService] Backport Breaking Change: Redact appsettings, storage-account, configs Apr 15, 2024
@bebound
Copy link
Contributor

bebound commented Apr 17, 2024

You need to update test_vm_image.py like #28751 to pass the test.
Related PR: #26543

@amberwang113
Copy link
Contributor Author

amberwang113 commented Apr 17, 2024 via email

@bebound
Copy link
Contributor

bebound commented Apr 18, 2024

@amberwang113 Could you please ask another engineer in your team to approve the PR? Thank you.

@amberwang113
Copy link
Contributor Author

@bebound No button for another engineer to approve the PR; he will leave a comment here

@shnjefff
Copy link
Member

@bebound This is Shengnan(Jeffery) from control plane. This pr looks good but I do not have the permission to approve. Can anyone in the reviewer approve this pr please?

@zhoxing-ms zhoxing-ms changed the title [AppService] Backport Breaking Change: Redact appsettings, storage-account, configs [App Service] Backport Breaking Change: Redact appsettings, storage-account, configs Apr 22, 2024
@zhoxing-ms
Copy link
Contributor

@amberwang113 @bebound Since this PR includes breaking change, could we consider moving it to the breaking change window of the next sprint for release (05-21)? Or is it a security related issue that must be released in this sprint?

@bebound
Copy link
Contributor

bebound commented Apr 23, 2024

It for 2.38 only, which does not follow normal release schedule.

Copy link
Member

@jiasli jiasli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving only for branch management.

@bebound bebound merged commit f11eee3 into Azure:2.38 Apr 24, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Functions az functionapp Logic App az logic Storage az storage Web Apps az webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants