-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Service] Backport Breaking Change: Redact appsettings, storage-account, configs #28671
Conversation
Hi @amberwang113, |
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
Validation for Breaking Change Starting...
Thanks for your contribution! |
AppService |
e1ce5ab
to
ccd0905
Compare
…ig connection-string and storage-account values (Azure#27629)
Got it - fixed now! Thanks.
From: Hang ***@***.***>
Sent: Tuesday, April 16, 2024 10:33 PM
To: Azure/azure-cli ***@***.***>
Cc: Amber Wang ***@***.***>; Mention ***@***.***>
Subject: Re: [Azure/azure-cli] [AppService] Backport Breaking Change: Redact appsettings, storage-account, configs (PR #28671)
You need to update test_vm_image.py like #28751<#28751> to pass the test.
Related PR: #26543<#26543>
-
Reply to this email directly, view it on GitHub<#28671 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BDC754MIVNGD43LKXVCMOUTY5YCRZAVCNFSM6AAAAABFSJ2SHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRQGM4DMNJTGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@amberwang113 Could you please ask another engineer in your team to approve the PR? Thank you. |
@bebound No button for another engineer to approve the PR; he will leave a comment here |
@bebound This is Shengnan(Jeffery) from control plane. This pr looks good but I do not have the permission to approve. Can anyone in the reviewer approve this pr please? |
@amberwang113 @bebound Since this PR includes breaking change, could we consider moving it to the breaking change window of the next sprint for release (05-21)? Or is it a security related issue that must be released in this sprint? |
It for 2.38 only, which does not follow normal release schedule. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving only for branch management.
Related command
az webapp config appsettings set/delete
az logicapp config appsettings set/delete
az functionapp config appsettings set/delete
az staticwebapp appsettings set/delete
az webapp config connection-string set/delete
az webapp config storage-account add/update/delete
Description
Backport fixes from #27565 and #27629 for issue #28631
Testing Guide
History Notes
[App Service] [BREAKING CHANGE] Redact appsettings output on set/delete commands
[App Service] [BREAKING CHANGE]
az webapp config
: Redact webapp config connection-string and storage-account valuesThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.