[App Service] BREAKING CHANGE: az webapp config: Redact webapp config connection-string and storage-account values
#27629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amberwang113
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
|
Thank you for your contribution amberwang113! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
added
the
customer-reported
|
App Service |
jiasli
reviewed
Oct 19, 2023
amberwang113
force-pushed
the
redact-config-connection-string
branch
from
c41ab53
to
f70dc42
Compare
amberwang113
force-pushed
the
redact-config-connection-string
branch
from
f70dc42
to
6be01c7
Compare
amberwang113
changed the title
…tring, and storage-account
|
Please rerun the test and upload the recording file. |
|
It is suggested to specify the related command in the title: |
amberwang113
changed the title
az webapp config: Redact webapp config connection-string and storage-account values
amberwang113
force-pushed
the
redact-config-connection-string
branch
from
fe26c7c
to
98934eb
Compare
amberwang113
force-pushed
the
redact-config-connection-string
branch
from
98934eb
to
5cc5e8f
Compare
|
Re-recorded the two affected tests and fixed title! @yanzhudd |
|
Please fix CI issues. |
|
Please resolve the code conflicts |
yanzhudd
approved these changes
Nov 3, 2023
5 tasks
3 tasks
amberwang113
added a commit
to amberwang113/azure-cli
that referenced
this pull request
Apr 15, 2024
…ig connection-string and storage-account values (Azure#27629)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp config connection-string set/delete
az webapp config storage-account add/update/delete
Description
Necessary to protect potential passwords in webapp connection strings and storage account access keys. Redacts outputs of set/delete (connection-string) by setting value for each added connection string to null. Redacts outputs of add/update/delete (storage-account) by setting accesskey for each added storage account to null. Added warning to indicate that behavior has changed and that users should use az webapp config connection-string/storage-account list to view values of the connection strings.
Testing Guide
For connection-string:
azdev test test-webapp-config
azdev test test-webapp-slot
For storage-account:
azdev test test_webapp_config
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.