Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App Service] BREAKING CHANGE: az functionapp: Redact key value output on keys set #27611

Merged
merged 6 commits into from
Nov 3, 2023
Merged

[App Service] BREAKING CHANGE: az functionapp: Redact key value output on keys set #27611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
14926de
Remove key value for 'keys set' and 'function keys set'
kamperiadis Oct 17, 2023
f15c2c8
Add warning for redacted values
kamperiadis Oct 17, 2023
98ef2c6
Add redaction note in documentation
kamperiadis Oct 27, 2023
5a06488
Rerun unit tests
kamperiadis Oct 31, 2023
11a3e20
Resolve merge conflicts
kamperiadis Nov 1, 2023
e928c74
Add missing test recordings
kamperiadis Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/_help.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -709,6 +709,7 @@
helps['functionapp function keys set'] = """
type: command
short-summary: Create or update a function key.
long-summary: Note that key values are now redacted in the result. Please use the `az functionapp function keys list` command to view the key values.
examples:
- name: Create a function key.
text: >
Expand Down Expand Up @@ -813,6 +814,7 @@
helps['functionapp keys set'] = """
type: command
short-summary: Create or update a function app key.
long-summary: Note that key values are now redacted in the result. Please use the `az functionapp keys list` command to view the key values.
examples:
- name: Create a function key for an Azure Function app.
text: >
Expand Down
50 changes: 30 additions & 20 deletions src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5381,15 +5381,21 @@ def update_host_key(cmd, resource_group_name, name, key_type, key_name, key_valu
}
client = web_client_factory(cmd.cli_ctx)
if slot:
return client.web_apps.create_or_update_host_secret_slot(resource_group_name,
name,
key_type,
key_name,
slot, key=key_info)
return client.web_apps.create_or_update_host_secret(resource_group_name,
name,
key_type,
key_name, key=key_info)
response = client.web_apps.create_or_update_host_secret_slot(resource_group_name,
name,
key_type,
key_name,
slot,
key=key_info)
else:
response = client.web_apps.create_or_update_host_secret(resource_group_name,
name,
key_type,
key_name,
key=key_info)
logger.warning('Keys have been redacted. Use `az functionapp keys list` to view.')
response.value = None
return response


def list_host_keys(cmd, resource_group_name, name, slot=None):
Expand Down Expand Up @@ -5434,17 +5440,21 @@ def update_function_key(cmd, resource_group_name, name, function_name, key_name,
}
client = web_client_factory(cmd.cli_ctx)
if slot:
return client.web_apps.create_or_update_function_secret_slot(resource_group_name,
name,
function_name,
key_name,
slot,
key_info)
return client.web_apps.create_or_update_function_secret(resource_group_name,
name,
function_name,
key_name,
key_info)
response = client.web_apps.create_or_update_function_secret_slot(resource_group_name,
name,
function_name,
key_name,
slot,
key_info)
else:
response = client.web_apps.create_or_update_function_secret(resource_group_name,
name,
function_name,
key_name,
key_info)
logger.warning('Keys have been redacted. Use `az functionapp function keys list` to view.')
response.value = None
return response


def list_function_keys(cmd, resource_group_name, name, function_name, slot=None):
Expand Down
Loading