[App Service] BREAKING CHANGE: az functionapp: Redact key value output on keys set
#27611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamperiadis
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
🔄AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
️✔️AzureCLI-BreakingChangeTest
|
|
App Service |
yanzhudd
reviewed
Oct 31, 2023
yanzhudd
reviewed
Oct 31, 2023
|
please rerun the test in live mode and upload the recording file. |
|
It is suggested to specify the command in the PR title: |
kamperiadis
changed the title
az functionapp: Redact key value output on keys set
@yanzhudd I have addressed all your feedback. Can you please help review this PR again and merge if it looks good? Thank you! |
yanzhudd
approved these changes
Nov 3, 2023
5 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp keys setaz functionapp function keys setDescription
Currently, these two commands return the key value as part of the output. In this PR, we are redacting the key value to prevent accidental security leaks through CI logs.
Testing Guide
az functionapp createaz functionapp keys set) or function keys (az functionapp function keys set)This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.