-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{packaging} Bump semver to 3.0.x #26523
Conversation
Many Linux distributions, including Fedora, have updated to semver 3.0.0. It would be helpful if azure-cli could use this newer version. Signed-off-by: Major Hayden <major@redhat.com>
️✔️AzureCLI-FullTest
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
Thank you for your contribution major! We will review the pull request and get back to you soon. |
packaging |
@@ -129,7 +129,7 @@ python-dateutil==2.8.0 | |||
requests-oauthlib==1.2.0 | |||
requests[socks]==2.26.0 | |||
scp==0.13.2 | |||
semver==2.13.0 | |||
semver==3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency on semver
was introduced by #16857. I have left a comment at #16857 (comment).
Thanks @major for your contribution. However, we decided we will drop the |
@major, as shown in Azure/azure-cli-extensions#6575 (comment) and #26797 (comment) we would want to keep the dependency on It'll be great if you can recreate the branch and reopen this PR, so that we can give you credit for submitting this PR. Thanks! |
@jiasli Will do. Thank you. |
Related command
N/A
Description
Many Linux distributions, including Fedora, have updated to semver 3.0.x. It would be helpful if azure-cli could use this newer version.
Testing Guide
No testing changes needed.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.