-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
containerapp add containerapp-preview extension #6419
containerapp add containerapp-preview extension #6419
Conversation
Thank you for your contribution! We will review the pull request and get back to you soon. |
wait #6397 |
src/containerapp-preview/azext_containerapp_preview/_clients.py
Outdated
Show resolved
Hide resolved
src/containerapp-preview/azext_containerapp_preview/_validators.py
Outdated
Show resolved
Hide resolved
...nerapp-preview/azext_containerapp_preview/tests/latest/test_containerapp_preview_scenario.py
Outdated
Show resolved
Hide resolved
remove empty file and make CI pass |
86dd794
to
aac0694
Compare
The CI check [Azure.azure-cli-extensions (CLI Linter on Modified Extensions)]failed due to our containerapp-preview rely on containerapp extension.
We should install containerapp and containerapp-preview both to pass the check. And I don't know why the [Verify Ref Docs] failed too. Is there any problem in test pipeline?
Thanks a lot! |
src/containerapp-preview/azext_containerapp_preview/commands.py
Outdated
Show resolved
Hide resolved
|
...nerapp-preview/azext_containerapp_preview/tests/latest/test_containerapp_preview_scenario.py
Show resolved
Hide resolved
...nerapp-preview/azext_containerapp_preview/tests/latest/test_containerapp_preview_scenario.py
Outdated
Show resolved
Hide resolved
This is a warning level detection, I did not judge the extension of the first onboarding, but it will not affect pr merge. |
5922333
to
03aa729
Compare
src/containerapp-preview/azext_containerapp_preview/__init__.py
Outdated
Show resolved
Hide resolved
src/containerapp-preview/azext_containerapp_preview/_validators.py
Outdated
Show resolved
Hide resolved
src/containerapp-preview/azext_containerapp_preview/commands.py
Outdated
Show resolved
Hide resolved
src/containerapp-preview/azext_containerapp_preview/containerapp_decorator.py
Outdated
Show resolved
Hide resolved
src/containerapp-preview/azext_containerapp_preview/containerapp_decorator.py
Show resolved
Hide resolved
Hi @zhoxing-ms This pr is ready to merge, could you please help to merge? Thanks a lot. |
I have a small suggestion: perhaps in the future versions (not necessary for the current version), we could consider using config ( |
[Release] Update index.json for extension [ containerapp-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=71512&view=results |
We will have 2 extension: containerapp and containerapp-preview.
Generally, in containerapp extension we use stable api-version, in containerapp-preview extension we could use preview api-version.
Preview extension can be used to overwrite the command in the GA extension, which give us the capability to put the stable-only feature in the GA extension and use the preview extension for the preview-only feature.
The containerapp-preview extension cannot run independently, it requires the containerapp extension.
Here is the discussion:Azure/azure-cli#25782
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.