Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARO] az aro create: v2022-04-01 API Feature Support #22320

Merged
merged 7 commits into from
May 16, 2022

Conversation

SudoBrendan
Copy link
Contributor

@SudoBrendan SudoBrendan commented May 9, 2022

Related command

az aro

Description

  • bump API version from 2020-04-30 -> 2022-04-01, and add supported features:
    • FIPS cryptography modules
    • disk encryption
    • host encryption
  • validation format string updates
  • correct code owners of ARO

Testing Guide

History Notes

{ARO} az aro: bump API version from 2020-04-30 to 2022-04-01
[ARO] az aro create: Add support for FIPS modules, host encryption, and disk encryption for master and worker nodes


This checklist is used to make sure that common guidelines for a pull request are followed.

- support for FIPs
- support for disk encryption
- validation updates
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label May 9, 2022
@ghost
Copy link

ghost commented May 9, 2022

Thank you for your contribution SudoBrendan! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Collaborator

yonzhan commented May 9, 2022

ARO

@SudoBrendan SudoBrendan marked this pull request as ready for review May 10, 2022 16:10
@zhoxing-ms
Copy link
Contributor

@SudoBrendan Same CI issue as #22100 (comment), Please wait for PR #22347 to solve this problem

@SudoBrendan SudoBrendan marked this pull request as draft May 12, 2022 21:34
@SudoBrendan
Copy link
Contributor Author

SudoBrendan commented May 12, 2022

I've converted this back to a Draft after realizing more about how the test setup works - I should have updated tests in the next few days.

EDIT: Or, it'll just work the first time :) Converting back.

@SudoBrendan SudoBrendan marked this pull request as ready for review May 12, 2022 23:20
Copy link
Member

@jiasli jiasli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for core.

@kairu-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms kairu-ms merged commit 58a8f65 into Azure:dev May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants