Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHubs]Add cmdlets for schema registry #22100

Merged
merged 19 commits into from
May 12, 2022

Conversation

damodaravadhani
Copy link
Contributor

Description
Add cmdlets to support schema registry for eventhubs.

Testing Guide
az eventhubs namespace schema-registry create -g {resourcegroup} --namespace-name {namespacename} --name s2 --schema-compatibility Forward --schema-type Avro

History Notes

[EventHubs] az eventhubs namespace schema-registry: Add cmdlets for schema registry


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the Auto-Assign Auto assign by bot label Apr 18, 2022
@ghost ghost assigned evelyn-ys Apr 18, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 18, 2022
@ghost ghost requested a review from yonzhan April 18, 2022 16:00
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 18, 2022

EventHubs

@damodaravadhani
Copy link
Contributor Author

Hello @evelyn-ys , could you please help figure out why the automation test pipelines are failing, it is pointing to a test in IOT Hub that is not out service. Thanks.

@evelyn-ys
Copy link
Member

As you have bumped the API version for eventhubs, then all module tests containing eventhubs commands should be re-recorded. IOT is just one of such tests.

@evelyn-ys evelyn-ys marked this pull request as draft April 22, 2022 01:47
@damodaravadhani damodaravadhani marked this pull request as ready for review April 22, 2022 08:49
@damodaravadhani
Copy link
Contributor Author

damodaravadhani commented May 9, 2022

Hey @evelyn-ys , these pipelines were passing until the last commit. I pushed in a small change, and for some reason it shows the tests in hybrid that I have already pushed recordings for as failed. And it points to a few tests in latest that do not use eventhubs at all. Could you please help me figure out what's wrong.

@damodaravadhani
Copy link
Contributor Author

image

It points to test in back up that doesn't use eventhubs, could you please help me find why is this the case ?

@evelyn-ys
Copy link
Member

@zhoxing-ms Can you help take a look at iot and backup failures?

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 10, 2022

Screenshot 2022-05-10 121913

       raise AssertionError(ex)

E AssertionError: Can't overwrite existing cassette ('/home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/backup/tests/latest/recordings/test_afs_backup_policy.yaml') in your current record mode ('once').
E No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Storage/storageAccounts/clitest000003?api-version=2021-09-01>) was found.
E Found 47 similar requests with 2 different matcher(s) :

The failure of these CI may be caused by the change of command storage account show-connection-string

For Iot related tests, this command is called by _get_azurestorage_connectionstring() method
For Backup related tests, this command is called by @FileSharePreparer()

@evelyn-ys I speculate this problem was introduced by PR #22280, this is caused by the new method call sa = scf.get_properties(resource_group_name, account_name) makes an additional request, could you help check it?

@evelyn-ys
Copy link
Member

Fix tests in #22347

@damodaravadhani
Copy link
Contributor Author

@evelyn-ys , can we have a review on this and merge this if there are no concerns further ? Thanks.

@evelyn-ys evelyn-ys merged commit 420da8c into Azure:dev May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants