Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting 'Per Site Scaling' on AppService plan create #11009

Merged
merged 3 commits into from
Oct 30, 2019
Merged

Support setting 'Per Site Scaling' on AppService plan create #11009

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d77ce28
Adding new parameter
Oct 19, 2019
b2d2df4
Adding support for per-app scaling on ASP create
panchagnula Oct 29, 2019
3ebc5da
Updating History
panchagnula Oct 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adding new parameter
  • Loading branch information
@panchagnula
Sisira Panchagnula authored and panchagnula committed Oct 29, 2019
commit d77ce283cddf31d30cbbfb6291724f46ea040d89
4 changes: 4 additions & 0 deletions src/azure-cli/azure/cli/command_modules/appservice/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ def load_arguments(self, _):
c.argument('sku', arg_type=sku_arg_type)
c.argument('is_linux', action='store_true', required=False, help='host web app on Linux worker')
c.argument('hyper_v', action='store_true', required=False, help='Host web app on Windows container', is_preview=True)
c.argument('per_site_scaling', action='store_true', required=False, help='EnablepPer-app scaling at the '
'App Service plan level to allow for '
'scaling an app independently from '
'the App Service plan that hosts it.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can put help= in a new line.

c.argument('tags', arg_type=tags_type)

with self.argument_context('appservice plan update') as c:
Expand Down
4 changes: 2 additions & 2 deletions src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1380,8 +1380,8 @@ def list_app_service_plans(cmd, resource_group_name=None):
return plans


def create_app_service_plan(cmd, resource_group_name, name, is_linux, hyper_v, sku='B1', number_of_workers=None,
location=None, tags=None):
def create_app_service_plan(cmd, resource_group_name, name, is_linux, hyper_v, per_site_scaling, sku='B1',
number_of_workers=None, location=None, tags=None):
if is_linux and hyper_v:
raise CLIError('usage error: --is-linux | --hyper-v')
client = web_client_factory(cmd.cli_ctx)
Expand Down