Support setting 'Per Site Scaling' on AppService plan create #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panchagnula
force-pushed
the
sisirap-igniteFix2
branch
from
6cddbdf to
43bb561
Compare
panchagnula
force-pushed
the
sisirap-igniteFix2
branch
from
43bb561 to
b2d2df4
Compare
qwordy
reviewed
Oct 29, 2019
| c.argument('per_site_scaling', action='store_true', required=False, help='Enable per-app scaling at the ' | ||
| 'App Service plan level to allow for ' | ||
| 'scaling an app independently from ' | ||
| 'the App Service plan that hosts it.') |
There was a problem hiding this comment.
Maybe you can put help= in a new line.
|
Update HISTORY.rst. Thanks. |
qwordy
reviewed
Oct 29, 2019
| @@ -205,6 +209,7 @@ def load_arguments(self, _): | |||
| c.argument('allowed_origins', options_list=['--allowed-origins', '-a'], nargs='*', help='space separated origins that should be allowed to make cross-origin calls (for example: http://example.com:12345). To allow all, use "*" and remove all other origins from the list') | |||
|
|
|||
| with self.argument_context(scope + ' config set') as c: | |||
| c.argument('number_of_workers', options_list=['--number-of-workers'], help='The number of workers to be allocated.', type=int) | |||
There was a problem hiding this comment.
thanks for the quick PR on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7888
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.