-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{vm-repair} Changing default windows image from the old 2016 to the 2022 image #8046
base: main
Are you sure you want to change the base?
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @Sandido, |
Hi @Sandido, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
This PR is in draft status |
Using Azure CLI to deploy a 2019-Datacenter-GS image does not work, it returns an error of OS Provision Timed out. |
Please fix conflicting files |
This is technically a breaking change, with the messaging being sent here: Default windows image change breaking change warning, Win2016 to Win2022 by Sandido · Pull Request #8045 · Azure/azure-cli-extensions (github.com)
Update: changing the image to 2022 smalldisk instead to reduce the breaking change impact and due to a known disk id conflict issue with identical images.
This change prevents the old 2016 image from being used by default, rather to a newer method that first tries to use the source VM image, and if that cannot be found it uses the 2022 image.
This PR should be released in time for the November Ignite breaking change release.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.