Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vm-repair} Changing default windows image from the old 2016 to the 2022 image #8046

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Oct 1, 2024


This is technically a breaking change, with the messaging being sent here: Default windows image change breaking change warning, Win2016 to Win2022 by Sandido · Pull Request #8045 · Azure/azure-cli-extensions (github.com)

Update: changing the image to 2022 smalldisk instead to reduce the breaking change impact and due to a known disk id conflict issue with identical images.

This change prevents the old 2016 image from being used by default, rather to a newer method that first tries to use the source VM image, and if that cannot be found it uses the 2022 image.
This PR should be released in time for the November Ignite breaking change release.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @Sandido,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 1, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Oct 1, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 1, 2024
@AllyW AllyW added the minor release extension module with version minor upgraded label Oct 8, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 8, 2024
@AllyW AllyW removed the minor release extension module with version minor upgraded label Oct 8, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 8, 2024
@AllyW AllyW added the major release extension module with version major upgraded label Oct 9, 2024
@Sandido Sandido changed the title Changing default windows image from the old 2016 to the new 2022 Changing default windows image from the old 2016 to the new 2019 Oct 14, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Oct 14, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 15, 2024

This PR is in draft status

@Sandido
Copy link
Member Author

Sandido commented Oct 16, 2024

Using Azure CLI to deploy a 2019-Datacenter-GS image does not work, it returns an error of OS Provision Timed out.
Maybe it does work if timeout is modified, but I am unable to verify that.

@Sandido Sandido changed the title Changing default windows image from the old 2016 to the new 2019 Changing default windows image from the old 2016 to the 2022 image Oct 23, 2024
@Sandido Sandido marked this pull request as ready for review October 23, 2024 20:41
@Sandido Sandido changed the title Changing default windows image from the old 2016 to the 2022 image {vm-repair} Changing default windows image from the old 2016 to the 2022 image Oct 25, 2024
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 26, 2024

Please fix conflicting files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension/vm-repair major release extension module with version major upgraded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants