Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default windows image change breaking change warning, Win2016 to Win2022 #8045

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Oct 1, 2024


This change is to bring our default image to Win2022 instead of 2016. This will bring our default image up to date with useful security updates.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 1, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @Sandido,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 1, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Oct 1, 2024

@Sandido Sandido marked this pull request as ready for review October 1, 2024 17:33
@Sandido
Copy link
Member Author

Sandido commented Oct 2, 2024

@zhoxing-ms , @yanzhudd , please review this for the current milestone so the breaking change warning can get in before the breaking change.

@zhoxing-ms zhoxing-ms merged commit 4cedb96 into Azure:main Oct 8, 2024
19 of 20 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Oct 8, 2024

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/release/_build/results?buildId=195175&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants