Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AKS: Add ephemeral disk volume type and nvme perf tier support to Azure Container Storage #7730

Merged
merged 17 commits into from
Jun 26, 2024
Merged

AKS: Add ephemeral disk volume type and nvme perf tier support to Azure Container Storage #7730

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
89f697a
Complete set of new cli changes for ephemeral disk volume type and pe…
mukhoakash Jun 19, 2024
ca9fbbf
Fixes in the test cases
mukhoakash Jun 20, 2024
7966625
Some more validations added. More lint fixes
mukhoakash Jun 21, 2024
e22fb86
Introducing live test for the new cli options
mukhoakash Jun 21, 2024
bec0c65
More lint and style fixes
mukhoakash Jun 21, 2024
e53c509
Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …
mukhoakash Jun 21, 2024
ddb5d04
Fixes to test cases and new test cases
mukhoakash Jun 22, 2024
5176fc8
Re-add pending in history
mukhoakash Jun 24, 2024
b66dc4f
Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …
mukhoakash Jun 25, 2024
339aaeb
Some more updates
mukhoakash Jun 25, 2024
d71b359
Adding comment for readability and clarification
mukhoakash Jun 25, 2024
66f5d30
Adding default values to acstor ops functions
mukhoakash Jun 25, 2024
a1edf22
Lint fixes
mukhoakash Jun 25, 2024
5853fa6
Lint fixes
mukhoakash Jun 25, 2024
53625cc
Lint fixes
mukhoakash Jun 25, 2024
389b3d9
Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …
mukhoakash Jun 25, 2024
d8171c5
Fixing a typo
mukhoakash Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint fixes
  • Loading branch information
@mukhoakash
mukhoakash committed Jun 25, 2024
commit 5853fa6c8e3aff406832ce8a77d9d6d7ab64ed28
16 changes: 8 additions & 8 deletions src/aks-preview/azext_aks_preview/azurecontainerstorage/_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,14 +451,14 @@ def check_if_new_storagepool_creation_required(
) -> bool:
# pylint: disable=too-many-boolean-expressions
if (
not is_extension_installed or \
not (is_ephemeralDisk_localssd_enabled or is_ephemeralDisk_nvme_enabled) or \
storage_pool_type != CONST_STORAGE_POOL_TYPE_EPHEMERAL_DISK or \
((ephemeral_disk_volume_type is None or
(existing_ephemeral_disk_volume_type.lower() == ephemeral_disk_volume_type.lower())) and
(ephemeral_disk_nvme_perf_tier is None or
(existing_ephemeral_nvme_perf_tier.lower() == ephemeral_disk_nvme_perf_tier.lower())))
):
not is_extension_installed or
not (is_ephemeralDisk_localssd_enabled or is_ephemeralDisk_nvme_enabled) or
storage_pool_type != CONST_STORAGE_POOL_TYPE_EPHEMERAL_DISK or
((ephemeral_disk_volume_type is None or
(existing_ephemeral_disk_volume_type.lower() == ephemeral_disk_volume_type.lower())) and
(ephemeral_disk_nvme_perf_tier is None or
(existing_ephemeral_nvme_perf_tier.lower() == ephemeral_disk_nvme_perf_tier.lower())))
):
return True

return False
Expand Down
Loading