-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AKS: Add ephemeral disk volume type and nvme perf tier support to Azure Container Storage #7730
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks create | cmd aks create added parameter ephemeral_disk_nvme_perf_tier |
||
aks create | cmd aks create added parameter ephemeral_disk_volume_type |
||
aks update | cmd aks update added parameter ephemeral_disk_nvme_perf_tier |
||
aks update | cmd aks update added parameter ephemeral_disk_volume_type |
Thank you for your contribution! We will review the pull request and get back to you soon. |
For more info about extension versioning, please refer to Extension version schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some live test cases for the newly added options?
src/aks-preview/HISTORY.rst
Outdated
@@ -13,12 +13,18 @@ Pending | |||
+++++++ | |||
* Vendor new SDK and bump API version to 2024-04-02-preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include this note as part of 5.0.0b2 as well
81e9d74
to
7966625
Compare
e45106f
to
f418fd7
Compare
Please fix CI issues |
f418fd7
to
1c9fc5d
Compare
1c9fc5d
to
ddb5d04
Compare
…into mukhoakash/new_acstor_cli
eed6e7f
to
f4ce0fa
Compare
f4ce0fa
to
339aaeb
Compare
I've fixed the common style/lint issue in aks-preview via another PR #7741, please rebase from main. |
980bf36
to
41528ef
Compare
41528ef
to
53625cc
Compare
…into mukhoakash/new_acstor_cli
Triggered live test:
|
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
Triggered new live test: test_aks_create_with_azurecontainerstorage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167719&view=results |
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=167768&view=results |
…re Container Storage (Azure#7730)
This PR adds support to change the ephemeral disk volume type ephemeral nvme perf tier for Azure Container Storage installations on AKS cluster.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.