Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Add --enable-azure-monitor-app-monitoring and --disable-azure-monitor-app-monitoring to aks-preview #7514

Merged
merged 16 commits into from
Apr 24, 2024
Merged

[AKS] Add --enable-azure-monitor-app-monitoring and --disable-azure-monitor-app-monitoring to aks-preview #7514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b8bda9a
Update help.py and custom.py
Apr 4, 2024
606edbc
Adding params.py
Apr 5, 2024
a91a202
Update managed_cluster_decorator
Apr 10, 2024
7eaf167
Add create test
Apr 10, 2024
838ea3d
Merge branch 'Azure:main' into jajataki/azure_monitor_profile
jatakiajanvi12 Apr 16, 2024
56a0b21
Update to use only two commands
Apr 16, 2024
b2956c5
Merge branch 'jajataki/azure_monitor_profile' of https://github.com/j…
Apr 16, 2024
a8929c2
Update the history and setup file
Apr 16, 2024
e930aec
Update help.py to remove other fields
Apr 16, 2024
dcc605d
Update the style check comments
Apr 16, 2024
6b10fa6
Update linter exclusions
Apr 16, 2024
8776a7e
Update the aks-preview linter_exclusions
Apr 16, 2024
accffe5
Spacing error
Apr 16, 2024
53e884b
resolving comments
Apr 17, 2024
8839393
Merge branch 'main' into jajataki/azure_monitor_profile
jatakiajanvi12 Apr 18, 2024
dc96814
update linter
Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolving comments
  • Loading branch information
Janvi Jatakia (from Dev Box) committed Apr 17, 2024
commit 53e884bdf949fff9ec72af7038347b6b51aabe21
4 changes: 2 additions & 2 deletions src/aks-preview/azext_aks_preview/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,8 +1207,8 @@ def load_arguments(self, _):
),
)
c.argument("disable_azure_monitor_metrics", action="store_true")
c.argument("enable_azure_monitor_app_monitoring", action="store_true")
c.argument("disable_azure_monitor_app_monitoring", action="store_true")
c.argument("enable_azure_monitor_app_monitoring", action="store_true", is_preview=True)
c.argument("disable_azure_monitor_app_monitoring", action="store_true", is_preview=True)
c.argument(
"enable_vpa",
action="store_true",
Expand Down
5 changes: 1 addition & 4 deletions src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10610,8 +10610,6 @@ def test_aks_create_with_azuremonitormetrics(
],
)

# live only due to downloading k8s-extension extension
@live_only()
@AllowLargeResponse(8192)
@AKSCustomResourceGroupPreparer(
random_name_length=17, name_prefix="clitest", location="westus2"
Expand Down Expand Up @@ -10840,7 +10838,6 @@ def test_aks_update_with_azuremonitormetrics(
],
)

@live_only()
@AllowLargeResponse(8192)
@AKSCustomResourceGroupPreparer(random_name_length=17, name_prefix='clitest', location='westus2')
def test_aks_update_with_azuremonitorappmonitoring(self, resource_group, resource_group_location):
Expand All @@ -10860,7 +10857,7 @@ def test_aks_update_with_azuremonitorappmonitoring(self, resource_group, resourc
self.check('provisioningState', 'Succeeded'),
])

# enabling or disabling azuremonitorappmonitoring
# no enabling or disabling azuremonitorappmonitoring
# will not affect any field in the cluster.
# the only check we should perform is to verify that the cluster is provisioned successfully.

Expand Down
6 changes: 3 additions & 3 deletions src/aks-preview/linter_exclusions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ aks create:
rule_exclusions:
- option_length_too_long
enable_azure_monitor_app_monitoring:
rule_extensions:
rule_exclusions:
- option_length_too_long
aks update:
parameters:
Expand Down Expand Up @@ -177,10 +177,10 @@ aks update:
rule_exclusions:
- option_length_too_long
enable_azure_monitor_app_monitoring:
rule_extensions:
rule_exclusions:
- option_length_too_long
disable_azure_monitor_app_monitoring:
rule_extensions:
rule_exclusions:
- option_length_too_long
aks delete:
parameters:
Expand Down
Loading