-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] Add --enable-azure-monitor-app-monitoring
and --disable-azure-monitor-app-monitoring
to aks-preview
#7514
Merged
yanzhudd
merged 16 commits into
Azure:main
from
jatakiajanvi12:jajataki/azure_monitor_profile
Apr 24, 2024
Merged
[AKS] Add --enable-azure-monitor-app-monitoring
and --disable-azure-monitor-app-monitoring
to aks-preview
#7514
yanzhudd
merged 16 commits into
Azure:main
from
jatakiajanvi12:jajataki/azure_monitor_profile
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atakiajanvi12/azure-cli-extensions into jajataki/azure_monitor_profile
jatakiajanvi12
requested review from
andyliuliming and
FumingZhang
as code owners
April 16, 2024 17:33
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks create | cmd aks create added parameter enable_azure_monitor_app_monitoring |
||
aks update | cmd aks update added parameter disable_azure_monitor_app_monitoring |
||
aks update | cmd aks update added parameter enable_azure_monitor_app_monitoring |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
jatakiajanvi12
changed the title
Add
[AKS] Add Apr 16, 2024
--enable-azure-monitor-app-monitoring
and --disable-azure-monitor-app-monitoring
to aks-preview--enable-azure-monitor-app-monitoring
and --disable-azure-monitor-app-monitoring
to aks-preview
FumingZhang
reviewed
Apr 17, 2024
FumingZhang
reviewed
Apr 17, 2024
FumingZhang
reviewed
Apr 17, 2024
FumingZhang
reviewed
Apr 17, 2024
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
FumingZhang
reviewed
Apr 17, 2024
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
FumingZhang
reviewed
Apr 17, 2024
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
FumingZhang
reviewed
Apr 17, 2024
FumingZhang
reviewed
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tokaplan
approved these changes
Apr 18, 2024
FumingZhang
approved these changes
Apr 19, 2024
ganga1980
reviewed
Apr 19, 2024
ganga1980
reviewed
Apr 19, 2024
ganga1980
reviewed
Apr 19, 2024
ganga1980
approved these changes
Apr 23, 2024
yanzhudd
approved these changes
Apr 24, 2024
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=151977&view=results |
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
…e-monitor-app-monitoring` to aks-preview (Azure#7514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
aks update --resource-group={resource_group} --name={name} ---enable-azure-monitor-app-monitoring
aks update --resource-group={resource_group} --name={name} ---disable-azure-monitor-app-monitoring
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.