{AKS} Add addon autoscaling preview CLI flag #7151
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter enable_addon_autoscaling |
||
| aks update | cmd aks update added parameter disable_addon_autoscaling |
||
| aks update | cmd aks update added parameter enable_addon_autoscaling |
|
Hi @chihshenghuang, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
chihshenghuang
requested review from
andyliuliming and
FumingZhang
as code owners
chihshenghuang
changed the title
src/aks-preview/setup.py
Outdated
| VERSION = "0.5.174" | ||
| VERSION = "0.5.175" |
There was a problem hiding this comment.
Could you please follow the version guideline to upgrade the extension version? https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md @chihshenghuang @FumingZhang
There was a problem hiding this comment.
Considering aks-preview is a preview extension, I suppose the next version number should be 0.6.0b1. Afterwards, as long as there is no breaking change, the version number will be incremented by the number after b (e.g., 0.6.0b2, 0.6.0b3, ...), otherwise the major will be updated (e.g., 1.0.0b1). Do I understand correctly? @zhoxing-ms
There was a problem hiding this comment.
In addition, I would like to clarify that whether the extension is a preview depends on whether its future design is stable and ensures that it does not cause any breaking changes to customers for a long time.
Therefore, even if the api-version used is preview, if you can ensure that the CLI interface remains unchanged, it can still release the GA extension version.
There was a problem hiding this comment.
In our new versioning, we never use 0.x.x any longer, just start from 1.0.0 (stable) or 1.0.0b1 (preview).
There was a problem hiding this comment.
In addition, I would like to clarify that whether the extension is a preview depends on whether its future design is stable and ensures that it does not cause any breaking changes to customers for a long time. Therefore, even if the api-version used is preview, if you can ensure that the CLI interface remains unchanged, it can still release the GA extension version.
Good point, I will confirm with PM whether aks-preview should continue to be a preview extension.
There was a problem hiding this comment.
Confirmed with PM lead, we are likely to make breaking changes in aks-preview, and we prefer to keep aks-preview as a preview extension.
Based on the new naming convention, I think the next version should be named as 1.0.0b1 (following would be 1.0.0b2, 1.0.0b3 without breaking change, and 2.0.0b1 if there's breaking change).
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=121342&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create --enable-addon-autoscaling
az aks update --enable-addon-autoscaling
az aks update --disable-addon-autoscaling
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.