Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the table columns to include ipv4,ipv6 #7145

Merged

Conversation

sushmak295
Copy link
Contributor

@sushmak295 sushmak295 commented Jan 4, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 4, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @sushmak295,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @sushmak295,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 4, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 4, 2024
@yonzhan yonzhan requested review from zhoxing-ms and yanzhudd January 4, 2024 00:37
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, please fix lint issues.

/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/_format.py:58:46: W291 trailing whitespace
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/_format.py:59:16: E111 indentation is not a multiple of 4
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/_format.py:60:48: W291 trailing whitespace
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/_format.py:61:16: E111 indentation is not a multiple of 4
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/_format.py:61:47: W291 trailing whitespace
/mnt/vss/_work/1/s/src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py:2183:5: E303 too many blank lines (2)

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Queued live test to validate the change. Test passed!

@yanzhudd
Copy link
Contributor

Please add changlog to HISTORY.rst. If you want to relase a new version for this change, please update the version in setup.py as well.

@zhoxing-ms
Copy link
Contributor

image
@sushmak295 Please remove the duplicated folder

@yanzhudd yanzhudd merged commit be4df69 into Azure:main Jan 24, 2024
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=124522&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants