Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wenjungao/fuming/aks vendor sdk 0823 #6685

Conversation

wenjungaogaogao
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 24, 2023

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks update cmd aks update removed parameter upgrade_settings please add back parameter upgrade_settings for cmd aks update
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_force_upgrade
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_force_upgrade

@azure-client-tools-bot-prd
Copy link

Hi @wenjungaogaogao,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 24, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@FumingZhang
Copy link
Member

Hey @wenjungaogaogao, any update on this PR?

@FumingZhang
Copy link
Member

change included in PR #6678

@FumingZhang FumingZhang closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants