Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Vendor new SDK and bump API version to 2023-07-02-preview #6678

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Aug 23, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Vendor new SDK and bump API version to 2023-07-02-preview, by commit #877d2d8.
  • [Breaking Change] Remove option --upgrade-settings from az aks update command, use option --enable-force-upgrade and --disable-force-upgrade instead, by commit #7026b32
    • The attribute controlPlaneOverrides in the rest API spec related to option --upgrade-settings is removed in API version 2023-07-02-preview, see #25099, #25254.
  • [Breaking Change] Deprecate option --dns-zone-resource-id from az aks create, az aks addon enable, az aks addon update and az aks enable-addons commands, use option --dns-zone-resource-ids instead, by commit #6142a97
    • To keep compatibility, option --dns-zone-resource-id is still available but hidden in help message.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 23, 2023

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks update cmd aks update removed parameter upgrade_settings please add back parameter upgrade_settings for cmd aks update
⚠️ 1006 - ParaAdd aks addon enable cmd aks addon enable added parameter dns_zone_resource_ids
⚠️ 1006 - ParaAdd aks addon update cmd aks addon update added parameter dns_zone_resource_ids
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter dns_zone_resource_ids
⚠️ 1006 - ParaAdd aks enable-addons cmd aks enable-addons added parameter dns_zone_resource_ids
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter disable_force_upgrade
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter enable_force_upgrade

@azure-client-tools-bot-prd
Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 23, 2023

AKS

Copy link
Contributor

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FumingZhang FumingZhang marked this pull request as ready for review August 29, 2023 08:01
@zhoxing-ms zhoxing-ms merged commit b7d8a30 into Azure:main Aug 29, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=86878&view=results

bgashirabake pushed a commit to bgashirabake/azure-cli-extensions that referenced this pull request Aug 30, 2023
@FumingZhang FumingZhang deleted the fuming/aks-vendor-sdk-0823 branch November 6, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants