Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in AMD64 connectedk8s cli for ARM64 clusters #5795

Merged
merged 12 commits into from
Feb 6, 2023
Merged

Changes in AMD64 connectedk8s cli for ARM64 clusters #5795

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0b6cdfd
switched to multi-arch images for troubleshoot
Jan 23, 2023
ab23029
removed arm64 warning from connect command and updated delete timeout…
Jan 23, 2023
a9bb5fd
nit
Feb 1, 2023
014de0f
merged master
Feb 1, 2023
95063b4
Merge branch 'master' into atharvam/arm64changesamd64cli
Feb 1, 2023
df941fe
Delete azure-arc-release NS in delete command
sikasire Feb 1, 2023
84e8894
remove default param
sikasire Feb 1, 2023
d8537eb
Update history.rst
sikasire Feb 1, 2023
5eb6457
Merge pull request #1 from atharvamulmuley/nsdelete
sirireddy12 Feb 2, 2023
bce89a7
updated image tag for troubleshoot
Feb 2, 2023
6840b74
nit
Feb 2, 2023
5f8054c
updated history and version
Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove default param
  • Loading branch information
@sikasire
sikasire committed Feb 1, 2023
commit 84e889472d3114ed5b7d30ad54441016ce255116
4 changes: 2 additions & 2 deletions src/connectedk8s/azext_connectedk8s/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,13 +484,13 @@ def cleanup_release_install_namespace_if_exists():
# Nothing to delete, exiting here
return
else:
kubernetes_exception_handler(ex, consts.Get_Kubernetes_Helm_Release_Namespace_Fault_Type, error_message='Unable to fetch details about existense of kubernetes namespace: {}'.format(consts.Release_Install_Namespace), summary='Unable to fetch kubernetes namespace: {}'.format(consts.Release_Install_Namespace), raise_error=True)
kubernetes_exception_handler(ex, consts.Get_Kubernetes_Helm_Release_Namespace_Fault_Type, error_message='Unable to fetch details about existense of kubernetes namespace: {}'.format(consts.Release_Install_Namespace), summary='Unable to fetch kubernetes namespace: {}'.format(consts.Release_Install_Namespace))

# If namespace exists, delete it
try:
api_instance.delete_namespace(consts.Release_Install_Namespace)
except Exception as ex:
kubernetes_exception_handler(ex, consts.Delete_Kubernetes_Helm_Release_Namespace_Fault_Type,error_message='Unable to clean-up kubernetes namespace: {}'.format(consts.Release_Install_Namespace), summary='Unable to delete kubernetes namespace: {}'.format(consts.Release_Install_Namespace), raise_error=True)
kubernetes_exception_handler(ex, consts.Delete_Kubernetes_Helm_Release_Namespace_Fault_Type,error_message='Unable to clean-up kubernetes namespace: {}'.format(consts.Release_Install_Namespace), summary='Unable to delete kubernetes namespace: {}'.format(consts.Release_Install_Namespace))


# DO NOT use this method for re-put scenarios. This method involves new NS creation for helm release. For re-put scenarios, brownfield scenario needs to be handled where helm release still stays in default NS
Expand Down