Changes in AMD64 connectedk8s cli for ARM64 clusters #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2023 19:01
ghost
added
ghost
requested review from
|
connectedk8s |
sirireddy12
reviewed
Jan 27, 2023
Delete azure-arc-release NS if exists as part of delete command
sirireddy12
approved these changes
Feb 2, 2023
|
Could you add some tests for this PR? |
@zhoxing-ms we are adding tests for all the code as part of this PR: #5566 |
zhoxing-ms
approved these changes
Feb 3, 2023
|
@atharvamulmuley Could you please add some description for this PR in the |
Added the description in the PR. History and version bump will happen in the next PR that will be merged after this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description