-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aks-preview: support csi drivers extensibility #4742
Conversation
aks-preview |
07bf84a
to
dae4bbb
Compare
src/aks-preview/azext_aks_preview/tests/latest/test_decorator.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_decorator.py
Outdated
Show resolved
Hide resolved
16df791
to
fdc879a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c.argument('enable_disk_driver', arg_type=get_three_state_flag()) | ||
c.argument('disable_disk_driver', arg_type=get_three_state_flag()) | ||
c.argument('enable_file_driver', arg_type=get_three_state_flag()) | ||
c.argument('disable_file_driver', arg_type=get_three_state_flag()) | ||
c.argument('enable_snapshot_controller', arg_type=get_three_state_flag()) | ||
c.argument('disable_snapshot_controller', arg_type=get_three_state_flag()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not recommend adding two completely opposite parameters repeatedly, because --enable-disk-driver True
can replace --disable-disk-driver False
, it will lead to too many similar parameters of CLI which will increase the learning cost of users. Moreover, it may also lead to conflicting usage of parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms so what's the suggestion? only use --enable-disk-driver
? and --enable-disk-driver False
looks weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few parameters following the same way in AKS: e.g.
c.argument('enable_public_fqdn', action='store_true')
c.argument('disable_public_fqdn', action='store_true')
c.argument('enable_ahub')
c.argument('disable_ahub')
c.argument('enable_azure_rbac', action='store_true')
c.argument('disable_azure_rbac', action='store_true')
c.argument('enable_secret_rotation', action='store_true')
c.argument('disable_secret_rotation', action='store_true')
c.argument('enable_cluster_autoscaler', options_list=[
"--enable-cluster-autoscaler", "-e"], action='store_true')
c.argument('disable_cluster_autoscaler', options_list=[
"--disable-cluster-autoscaler", "-d"], action='store_true')
c.argument('enable_pod_identity', action='store_true')
c.argument('disable_pod_identity', action='store_true')
c.argument('enable_workload_identity', arg_type=get_three_state_flag(), is_preview=True)
c.argument('disable_workload_identity', arg_type=get_three_state_flag(), is_preview=True)
Signed-off-by: Ji An Liu <jiliu8@microsoft.com>
fdc879a
to
3839f2a
Compare
@zhoxing-ms @FumingZhang |
Queued a pipeline to test the newly added options, works like a charm! |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.