aks-preview: support csi drivers extensibility #4742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ghost
assigned 
|
aks-preview |
ZeroMagic
force-pushed
the
jiliu8/disable-csi
branch
6 times, most recently
from
07bf84a
to
dae4bbb
Compare
FumingZhang
reviewed
Apr 29, 2022
src/aks-preview/azext_aks_preview/tests/latest/test_decorator.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_decorator.py
Outdated
Show resolved
Hide resolved
ZeroMagic
force-pushed
the
jiliu8/disable-csi
branch
5 times, most recently
from
16df791
to
fdc879a
Compare
zhoxing-ms
reviewed
May 5, 2022
Comment on lines
+330
to
+335
| c.argument('enable_disk_driver', arg_type=get_three_state_flag()) | ||
| c.argument('disable_disk_driver', arg_type=get_three_state_flag()) | ||
| c.argument('enable_file_driver', arg_type=get_three_state_flag()) | ||
| c.argument('disable_file_driver', arg_type=get_three_state_flag()) | ||
| c.argument('enable_snapshot_controller', arg_type=get_three_state_flag()) | ||
| c.argument('disable_snapshot_controller', arg_type=get_three_state_flag()) |
There was a problem hiding this comment.
We do not recommend adding two completely opposite parameters repeatedly, because --enable-disk-driver True can replace --disable-disk-driver False, it will lead to too many similar parameters of CLI which will increase the learning cost of users. Moreover, it may also lead to conflicting usage of parameters
There was a problem hiding this comment.
@zhoxing-ms so what's the suggestion? only use --enable-disk-driver? and --enable-disk-driver False looks weird.
There was a problem hiding this comment.
there are a few parameters following the same way in AKS: e.g.
c.argument('enable_public_fqdn', action='store_true')
c.argument('disable_public_fqdn', action='store_true')
c.argument('enable_ahub')
c.argument('disable_ahub')
c.argument('enable_azure_rbac', action='store_true')
c.argument('disable_azure_rbac', action='store_true')
c.argument('enable_secret_rotation', action='store_true')
c.argument('disable_secret_rotation', action='store_true')
c.argument('enable_cluster_autoscaler', options_list=[
"--enable-cluster-autoscaler", "-e"], action='store_true')
c.argument('disable_cluster_autoscaler', options_list=[
"--disable-cluster-autoscaler", "-d"], action='store_true')
c.argument('enable_pod_identity', action='store_true')
c.argument('disable_pod_identity', action='store_true')
c.argument('enable_workload_identity', arg_type=get_three_state_flag(), is_preview=True)
c.argument('disable_workload_identity', arg_type=get_three_state_flag(), is_preview=True)
Signed-off-by: Ji An Liu <jiliu8@microsoft.com>
ZeroMagic
force-pushed
the
jiliu8/disable-csi
branch
from
fdc879a
to
3839f2a
Compare
|
@zhoxing-ms @FumingZhang |
|
Queued a pipeline to test the newly added options, works like a charm! |
zhoxing-ms
approved these changes
May 7, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.