-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] support csi drivers extensibility #23654
Conversation
AKS |
src/azure-cli/azure/cli/command_modules/acs/managed_cluster_decorator.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Ji An Liu <jiliu8@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you have a look @zhoxing-ms |
Could you write the history notes for the feature of these new parameters in the PR description like #23324 |
Updated the description |
Related command
az aks create [--disable-disk-driver] [--disable-file-driver] [--disable-snapshot-controller]
az aks update [--disable-disk-driver] [--disable-file-driver] [--disable-snapshot-controller] [--enable-disk-driver] [--enable-file-driver] [--enable-snapshot-controller]
Description
With the feature, customers can enable/disable the CSI Drivers in their clusters according to demand.
Testing Guide
pyttest test_managed_cluster_decorator.py
azdev test acs.test_aks_create_and_update_with_csi_drivers_extensibility --live
azdev test acs.test_aks_create_with_standard_csi_drivers --live
History Notes
[AKS]
az aks create/update
: Add new parameters--enable-disk-driver
and--disable-disk-driver
to enable/disable AzureDisk CSI Driver. When creating new cluster, AzureDisk CSI Driver is enabled by default.[AKS]
az aks create/update
: Add new parameters--enable-file-driver
and--disable-file-driver
to enable/disable AzureFile CSI Driver. When creating new cluster, AzureFile CSI Driver is enabled by default.[AKS]
az aks create/update
: Add new parameters--enable-snapshot-controller
and--disable-snapshot-controller
to enable/disable CSI Snapshot Controller. When creating new cluster, CSI Snapshot Controller is enabled by default.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.