Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh 6.4 updates #430

Merged
merged 99 commits into from
Dec 4, 2018
Merged

mesh 6.4 updates #430

merged 99 commits into from
Dec 4, 2018

Conversation

jeffj6123
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

Jeffrey Jarry and others added 30 commits July 25, 2018 09:23
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/jeffj6123/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

@williexu
Copy link
Contributor

Please fix the CI, the metadata added must match the METADATA.json from your wheel.
Also, please rebase from master to update this PR

@jeffj6123
Copy link
Contributor Author

How can I add a do not merge tag? I wanted to get the PR ready but it might be a few days before it should get merged in.

@williexu
Copy link
Contributor

williexu commented Dec 3, 2018

@jeffj6123 done :)

@jeffj6123
Copy link
Contributor Author

#signoff

@belmaiastar belmaiastar merged commit cfd7e00 into Azure:master Dec 4, 2018
ShreyaAnand pushed a commit to ShreyaAnand/azure-cli-extensions that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants