Add IoT and Batch extension to index #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
zmssp
pushed a commit
to zmssp/azure-cli-extensions
that referenced
this pull request
Feb 26, 2021
Sync with the official repo
calvinsID
referenced
this pull request
in calvinsID/azure-cli-extensions
Mar 5, 2021
Use custom sdk code for app service plan command sdk
smile37773
pushed a commit
to smile37773/azure-cli-extensions
that referenced
this pull request
May 28, 2021
ninpan-ms
pushed a commit
to ninpan-ms/azure-cli-extensions
that referenced
this pull request
Jul 16, 2021
Synced with the official repo
zhoxing-ms
pushed a commit
that referenced
this pull request
Oct 27, 2021
* add appservice-kube extension * Retrieving function triggers from the function image * Retrieving function triggers from the function image * Fix appservice kube list by subscription * Fix transient error when loading arguments * Added az webapp up support * Handled code review comments * bump up version to 0.1.1 * Use custom sdk code for app service plan command sdk * Version 0.1.2 * Private registry image support and fixig windows to unix line feed char issue to retrive triggers from a function app * Removing debugpy.breaspoint() line * Update custom.py Removing trailing white spaces * Update custom.py Removing trailing white spaces * fixing the condition when the image is from the public registry with no user name and password supplied * Update sdk, add BYO AKS cluster to kube create command * Add version 0.1.3 * Copying getfunctionsjson.sh as part of appservice-kube extension and correcting the lookup path * Adding version 0.1.4 * fix * Update version to 0.1.5 * Update kube environments SDK * Add version 0.1.6 * Update kube environments SDK (using api version 2020-06-01), delete old parameters from commands * Add version 0.1.7 * remove azure-cli-core dependency * Add version 0.1.8 * Add latest changes from cli core (except az webapp up) * Bugfix: if ftp deployment profile doesn't exist, zip deploy fails * Bugfix: index.json had weird merge conflict * Bugfix: webapp config container set wasn't setting * Version 0.1.9 * Add functionapp config container set * Start referencing main cli * Functionapp deployment source config-zip command fix (copy over from main CLI for now) * Functions CLI should not pull docker image * Plan creation should drop --kube-environment and --kube-sku * Change kind to 'linux,kubernetes' * Help text changes * Publish extension v 0.1.10 * Version 0.1.11, since broke appservice plan create for non-k8se plans * Allow specifying custom location by name rather than resource ID * az appservice kube create command * Change ASP kind back to K8SE, reserved to None * Publish 0.1.12 whl * az webapp create doesn't require plan for k8se * Change app service plan kind to 'linux,kubernetes' and reserved=true if linux * Webapp create should pass with ASP kind=linux if SKU is a kube sku * az functionapp create without plan * Fix bug where if webapp/functionapp create called to update, if --plan isnt specified it creates new plan * fix webapp/functionapp create, if calling create again with new custom location/plan edge cases * Version 0.1.13 * Version 0.1.14 temporary change to stop doing the list in web/func app creates * Add better help text for appservice create with custom location * Update appservice SDK for kube extension to 2020-12-01 * Clean up az kube create * Update to version 0.1.15 * Fix dotnet5 bug * Converting skus for kubernetes ASPs to the new values * 0.1.16 version * Set number of workers to 1 when creating ASP * Add webapp scale command * Version 0.1.17 with az webapp scale * rename az webapp scale param * Move restart in from main CLI, since api returns 202 rather than 200. Need SDK update * Change SDK to have extended location envelope manually - need to see why generating SDK locally is failing * Pass ExtendedLocationEnvelope to web/functionapp, appservice plan and kube environment creates * Version 0.1.18 * Remove webapp up from extension * Use delete_app_settings function from cli core * Use webapp validator from core CLI * Use updated update_app_settings function from core CLI * 0.1.19 version * Fix regression when using main CLI validators * 0.1.20 version * az appservice kube create: better error message when conflict * Remove vsts_cd_manager * Version 0.1.21 * Update index.json * K8se master kube env create validations (#3) * az kube create: allow using custom location name. Also get location from custom location rather than resource group * Require cli core 2.26.0 or later * Version 0.2.0 * Use ExtendedLocation property ob object level (#4) * Static ip not required property in kube create * Version 0.2.1 * Fix NoneType object has no attribute custom_location error * Bugfix: Wrong custom location being used if multiple custom locations exist in diff rg (#5) * Fix NoneType object has no attribute custom_location error * If two custom locations with same name, in different resource group sometimes it uses wrong custom location * Version 0.2.2 * remove old SDK and start 'az appservice kube' rewrite * rewrite 'az appservice kube show' * rewrite 'az appservice kube list' * rewrite 'az appservice kube delete' * re-add appservice kube create checks and start appservice kube update impl * raise exception for 'az appservice kube update' * add 'az appservice kube wait' * add kube list pagination * fix 'az appservice create' * fix 'az appservice plan update' * fix 'az webapp create' * fix az webapp show/restart * remove 'az webapp config container set' * remove uneeded TODOs * format results of 'az appservice kube show/list' * remove TODOs and fix 'az webapp show -s' * add misc style fixes * fix more style issues * revert src/index.json to master version * add summary * fix linter issues * remove out-of-date test * fix appservice kube CLI linter issues * fix ASP sku validation * fix style * increment appservice-kube release number and fix service_name.json * fix hardcoded 'verify_linter.py' * add testing -- WIP * update codeowners and fix 'az appservice kube list' bug * remove unfinished tests * remove unnecessary branching * remove unnecessary options lists * use specific CLI error types * use more specific error type * fix more error types * use HttpResponseError * fix style * revert version and erase history Co-authored-by: Eben Carek <ebcarek@microsoft.com> Co-authored-by: Satish Ranjan <satishra@microsoft.com> Co-authored-by: Sanchit Mehta <sanchit.mehta602@gmail.com> Co-authored-by: Eben Carek <ebengc@gmail.com> Co-authored-by: SatishRanjan <SatishRanjan@users.noreply.github.com> Co-authored-by: Calvin Chan <calvinch4n@gmail.com>
Jing-song
referenced
this pull request
in Jing-song/azure-cli-extensions
Nov 24, 2021
modified set_build_in_bundles
zhoxing-ms
pushed a commit
that referenced
this pull request
Feb 21, 2022
* Use userValues.txt instead of --resuse-values in update command * fix error msg * added custom cert * change setup.py * Helmupdatefix (#4) * Use userValues.txt instead of --resuse-values in update command * fix error msg Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com> * fix output file * Helmupdatefix (#5) * Use userValues.txt instead of --resuse-values in update command * fix error msg * fix output file Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com> * place values file in .azure folder * place values file in .azure folder * Helmupdatefix (#6) * Use userValues.txt instead of --resuse-values in update command * fix error msg * fix output file * place values file in .azure folder * place values file in .azure folder Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com> * place values file in .azure folder * nit * nit * nit * setp.py and history.rst updates * modify the way of fetching userValues.txt path * Waiting for LRO to complete before moving ahead with agent installation/deletion * update history.rst * fix * fix location variable Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com> Co-authored-by: siriteja <32883500+sirireddy12@users.noreply.github.com>
runefa
added a commit
to runefa/azure-cli-extensions
that referenced
this pull request
Apr 22, 2022
Api changes
cormacpayne
pushed a commit
to cormacpayne/azure-cli-extensions
that referenced
this pull request
May 9, 2023
Fixed command usage text
cormacpayne
pushed a commit
to cormacpayne/azure-cli-extensions
that referenced
this pull request
May 15, 2023
* Adding patch list * Added patch list command * Revert thumbprint arg * Fix bugs * Integrated with Harry * Fixed bug * Fixed command usage text * Made managed env optional * Fixed identation * Fixed identation * Made env optional * Remove patch list * Update help text for patch list and patch run * Modified help text * Made resouce group optional * Added custom telemetry * Fixed linting errors --------- Co-authored-by: harrli <harrli@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com>
wangzelin007
pushed a commit
to wangzelin007/azure-cli-extensions
that referenced
this pull request
Jul 11, 2023
* Add temporary build workflow for AOSM extension * Add Releaser to maintain a release with the latest build in a consistent place
yanzhudd
pushed a commit
that referenced
this pull request
Oct 24, 2023
* removed deploy with sdk * added artifact list * push example cnf bicep * Add temporary build workflow for AOSM extension (#4) * Add temporary build workflow for AOSM extension * Add Releaser to maintain a release with the latest build in a consistent place * added output dir; fixing getchartmappingschema * Add empty init files to inner modules so setuptools recognises them as modules * Use latest RG model to remove unnecessary dependency on version * Use latest deployment model to remove unnecessary dependency on version * fixed parameter mappings + copied needed files to output folder * jinja2 and find value paths * fixed typos + self.aritfacts only has unique artifacts * use regex instead of string to find deploy params * delete accidentaly commited input.json * fixed deploy params; added indent to mapping file * Update readme with install/bug reporting instructions * Adjust headers so rendered readme looks nicer * renamed values.nondef + added cli errors * Split help command example lines * Clarify that bug process is internal * fixed parameter vals not updating * delete unuseed temoplate and update jinja2 templates * Update README.md * Update README.md * added docstrings; added basic error catching with file handling * small refactor of generate nfd * fixed j2 template captions; added create_nfd to cnf; edited error messages; added deleting existing folder to custom.py * fixed file not found erroe * Refactor commands to az aosm nfd|nsd build (#10) * Refactor commands to az aosm nfd|nsd build * setup.py version * Version was wrong * remove publish option from build * lint * wrong params * fixed most style errors; ran static checks and azdev style * pre merge commit * more style changes; renamed vnfbicepnfd to vnfnfd * Update readme with workflow * added configfile validation * added temp dir to vnf; renamed shared constants * sunny markups * removed create_nfd_folder; added schema prefix to constant * added deploymentparams to constants.py * added error catching for get chart name and version * added meaningful logs; prevent auto overwriting input.json * edited vnf schema to have accepted types * added templates to setup.py * added location from input file not resourceGroup().location * added path_to_mappings to input.json; added logic to take mappings from file outside of helm package * renamed non_def_values to mappings_path * Pk5/add nsd cli (#15) * First working version of the CLI NSD create * Fully working version of the NSD CLI * minor change to nsd_generate * Sunny's refactor * First round of cleanup * Secound Round of cleanup * fix the 2023 api NSDV * description updates * deleted comment * Fix SNS creation * Fix SNS creation try 2 * markups * delete unnecessary file * Testing markups * Fix the SNS attempt 3 * minor fixes * Fix config validation * fix CNF depends on * initial commit; ran python static checks fmt (except on vendored sdks), fixed styling on _configuration.py * Name uploaded VHD correctly * Self review markups * broken config generation code * fixed up configuration.py * fixed cnf generator styling * fixed styling for cnf generator * fixed up nfd generator base and deploy with arm * fixed styling for artifact.py * fixed styling for atrifact manifest .py * Code review markups * fixed more linting * first attempt at regex * Sunny/choose deploy parameters (#23) * choose-deploy-parameters * optioned deployParameters for CNF * lint * lint2 * docs * docs * lint * 9.82 score * Fix bugs * more useful debug logs * Fix bugs and logging * lint * markups * Fix for oras target string with erroneous spaces * fixed regex; tested on existing charts and sas charts; committing to not lose prints for testing * changed regex constants + tidied * fixed blankspace * markups * initial commit * tidied code and added comments * add multi nf config * Add style and lint check * added logic for handling deployparams within lists * one line fix from review * removing print statement * added new test file and one unit test * added workflow for unit tests in pipeline + set up rough structure of unit testing * instantiated cnf class; added fake invalid helm package; added new files to use for testing * Nsd for cnfs (#33) * NSD building for CNFs * linting * Add Publish command to the CNF azure CLI (#24) * Working publish * Fix the artifact upload * Working image copy * minor fix * Minor fixes * sunny merge add-aosm-extension into patryk's branch (#25) * Sunny/choose deploy parameters (#23) * choose-deploy-parameters * optioned deployParameters for CNF * lint * lint2 * docs * docs * lint * 9.82 score * Fix bugs * more useful debug logs * Fix bugs and logging * lint * markups * comment out breaking line * minor TODOs * deleted comment * fix bring your own parameters * Markups * Fix the helm upload * Minor markups * Change error message --------- Co-authored-by: sunnycarter <36891339+sunnycarter@users.noreply.github.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> * Expose NFD version and managed identities (#34) * NFDV version exposed as a CGV on an SNS * Managed identities support on NFs * Fix identiy, fix API versions * history --------- Co-authored-by: Jamie Parsons <jamie.parsons@metaswitch.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> * Add a first VNF test * achurchard/style fixes (#35) Fix style issues raised by `azdev style` * Add CNF UTs that will fail at the moment * Actually include all files. * Always run tests * Add another test that won't pass yet * remove github pipeline tests - they should run in Azure * Sundry fixes for CNF quickstart (#38) * Sundry fixes for CNF quickstart * merge add-aosm-ext in (#37) * markups * NSD UTs * Update read me. * Improve path handling, other small refactorings (#39) # Main changes ## Make methods relying on self._tmp_dir private - `self._tmp_dir` is only available in the context of calling `generate_nfd()`, so methods relying on `self._tmp_dir` should be private ## Use pathlib.Path rather than os file operations - Provides clearer and stronger typing than passing `str`s around - Adds some handy utility functions ## Variable renaming for clarity - E.g. consistently use 'directory' / 'dir' (rather than mix with 'folder') - Obvs somewhat subjective, but as someone new to most of this code, the changes made sense to me ## Add nfd_bicep_path as abstract property on NFDGenerator - We rely on it when calling the concrete implementations - Also use ABC rather than raise NotImplementedError ## Miscellaneous style updates to keep `azdev style aosm` happy - isort - black * Fix Artifact upload on Windows (#40) * Black * Mark ups * Sunny/fix artifact upload windows (#41) * Fix Artifact upload on Windows * mypy fixups * mypy fixes * linting * mypy * mypy for _configuration.py * mypy for vnf_nfd_generator.py * mypy appeasement * python-static-checks fmt * az style happy * lint * mypy cnf_nfd_generator * copyright * more lint * Remove windows oras workaround now 0.0.18 oras out * history --------- Co-authored-by: Jamie Parsons <jamie.parsons@metaswitch.com> * Fix VNFD build (#42) * Multiple instances of the same NF * fix vnf deploy schema types (#44) * Tidy up * Mypy and docs * history.rst * Update README with logging info (#43) * Update README with logging info * Update docs * self markups * Take oras 0.1.19 to fix Windows artifact upload (#46) * Rename a few things * DRY the deploy_nfd_from_bicep code * Make conditional statements clearer * black * Update custom.py to use new nfd deploy method * Black with text processing * Create new nfRET class * Mypy passing * UTs passing * Dry the deploy_nfd_from_bicep() code (#48) - Removed duplicated code in the deploy_vnfd_from_bicep() and deploy_cnfd_from_bicep() methods - Moved variables onto the class instance and stopped passing them around in the method signatures - Also made the deployer class a dataclass for cleaner __init__ - Made parameters a property of the class, and moved the logic for getting/generating them into that property method - Improved the typing - Included adding enums for SkipSteps and DeployableResourceTypes - Added the new skip step logic for image uploads - Added a new skip step type of IMAGE_UPLOAD Testing: - No MyPy errors - Live tests for VNFS+NSD, CNFs, including all --skip options * Unit tests added * Versions are wrong in NSD template comments * Self review markups * Remove wrong comments * Code review markups * Extra markups * Fix mypy * Pk5/add integration tests (#51) * Somewhat working example * Cleanups * Update recording * fix minor linting error * More markups * Update output in tests * Pk5/minor integration tests changes (#52) * Modify changelog and rename tests * Delete recording file * Update recordings * Update developer docs * Remove credentials * Fix linting * cheeky extra change * Remove credentials from the integration test recordings (#54) * Modify changelog and rename tests * Delete recording file * Fix the credentials issue in the integration tests * Update CHANGELOG * Markups * Fix typo * Minor markups * Make cleaning up resources more robust and remove the VHD external reference * Markups * Remove the integration test from the repo (#56) * prerequisite docker for cnf * Fix bicep render on Windows (#57) * Fixes for Windows (#58) * Fix bicep render on Windows * Fixes for Windows * python-static-checks ran * ADO-880627: Use docker-less ACR login For running in environments without docker, such as CI pipelines. This affects uploading Helm charts for CNFs - the ACR login now fetches an access token, which is used to login to the Helm registry and upload the chart. * docker is not required any more * Remove pre-release build and lint files from release branch (#63) * Release markups - release branch (#65) * Markups from release comments * history * markups and fixes * README changes * linting fixes * Fix integration tests (#67) * Fix integration tests * Update src/aosm/development.md Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * Markup changes --------- Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> * Add aosm to service_name.json * move artifact upload to before nfd/nsd deploy (#62) * move artifact upload to before nfd/nsd deploy * markups * check in new test recording * non-working attempt to use token creds * Check for Azure features on deploy and delete (#71) * WIP: Check for features on deploy and delete * linting * Anand has confirmed names of flags * Update test recording as now has calls to Features API * Update src/aosm/azext_aosm/custom.py Co-authored-by: jamiedparsons <111778988+jamiedparsons@users.noreply.github.com> * docstring markups --------- Co-authored-by: jamiedparsons <111778988+jamiedparsons@users.noreply.github.com> * code working * Fix generate-config * Fix tests * lint * linting * Jl/nfdv proxy (#73) * added publisher scope to input file; changed to proxy nsdv * fixed get request on proxy nfdv (should be overwritten when autogenerated again) * small print bug fix --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Code review mark ups * Linting and fix UTs * aosm codeowner * Update HISTORY.rst * Normalise aosm version to 1.0.0b1 for release * update hashes in recording * Temporary test revert of "aosm codeowner" This reverts commit 479ba54. * Fix license header formatting * Revert "Temporary test revert of "aosm codeowner"" This reverts commit 0e4d0e7. * Remove nonexistent entry from codeowners * Fix source_local_docker_image defaults to placeholder text (#79) * temp fix for bug * minor formatting * refactor + change validation ordering to mimic previous behaviour * add docstring --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * renamed nsdg to nsd * Helptext + a little bit of validation * Fixed up validation * Return True if _all_ required artifact manifests exist, not just the last one checked. * Code markups + linting. * Docs: CNF publish options and permissions (#91) * Requirement for docker again * revert bad markup (#94) * Move live tests to swedensouth * Actually move to uaenorth * Don't log out ACR passwords when artifact commands fail (#97) * Don't log out passwords when artifact commands fail * Don't log out passwords when artifact commands fail part 2 * Comment to explain dropping the original exception * Fix cnf image take 2 (#101) * Fix CNF image copy to work cross subscription * Cross subscription works for image copy. Still test same subscription * lint * Error message * oops, code paste error * markups * appease mypy * Default RG and ACR Values with Publisher Name (#103) * added default rg and acr values for nf + nsd; added blob_url default for vnf * added bug fix to close Paulo's bug * change error message back --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> * Fix unauthorized error bug * Add spacing * fix unexpected symbol when parsing lists (#107) * Validation requirements on helm names (#109) * Validation requirements on helm names * lint * markups * lint * Fix error parsing * Lower case acr names (#112) * Lower case ACR names and fix interactive mode for lists * lint * remove duplicate else branch * always allow azureDeployLocation to be configurable * Add new optional VHD parameters * Make VNF publish and delete a live test only * Validate VHD parameters in build UT * Markups from the CLI team * mark-ups * remove azureDeployLocation as a configurable vhd parameter * add explanitory comments * Updates for 2023-09-01 API (#84) * Regen Python SDK from 2023-09-01 API - also uses latest AutoRest client - fix for HybridNetworkManagementClient init signature (swap order of subscription_id and credential parameters) * Update CLI extension code to use new SDK * added SAMI to publisher pre deploy * Update bicep templates to use 2023-09-01 * Update NF templates * Update metaschema * Add Allow-Publisher to required feature flags * Use secure objects for deployment parameters * Correctly get array item types in CNF deployment parameter schemas * Revert master .flake8 config * Fix double space in user output. Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Remove delete message to be consistent with other CLI extensions * Move "Deleted <resource>" messages to logger.info(). * Remove Blob_SAS_URL Option from ArmTemplate in input file (#119) * moved blob url to vhd config only; untested * stopped error in post innit before validate * changed ordering of inputs so that blob and filepath are next to each other; helptext for filepath different for each option * Markups from sunny * appease mypy --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Sunny Carter <sunny.carter@metaswitch.com> --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Jacob Darby <jdarby@microsoft.com> Co-authored-by: Chaos <chaosultima@outlook.com> Co-authored-by: Chaos Chhapi <chaos.chhapi@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com> Co-authored-by: patrykkulik-microsoft <116072282+patrykkulik-microsoft@users.noreply.github.com> Co-authored-by: Jacob <53872686+jddarby@users.noreply.github.com> Co-authored-by: Jamie Parsons <jamie.parsons@metaswitch.com> Co-authored-by: jamiedparsons <111778988+jamiedparsons@users.noreply.github.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> Co-authored-by: William Bradley <wbradley@microsoft.com> Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
kairu-ms
pushed a commit
that referenced
this pull request
Apr 28, 2024
* fix: --title --kind --custom-property parameters (#1) * feat: support yaml file in register command (#3) * fix: workspace parameter should not be required (#2) * style: fix lint issues (#6) * chore: update codeowner for apic-extension (#5) * feat: revert changes to min cli version (#4) * feat: resolve comments to CLI experience (#10) * feat: mark "apic api register" command as preview (#13) * feat: remove --terms-of-service parameter (#12) * feat: remove --workspace-name parameter (#11) * feat: support python 3.8 and 3.9 (#14) * feat: fix command descriptions (#17) * tests: add test cases for 'apic service' commands (#16) * feat: Use 03-01 spec from azure-rest-api-specs repo to regenerate CLI (#19) * fix: CLI errors (#20) * fix: import error when run CLI command * fix: no workspace name error when run import specification command * feat: mark some parameters as required (#21) * feat: mark --assignments parameter required for metadata commands * doc: update sample commands * feat: mark --source-resource-ids parameter as required for import-from-apim command * doc: update description for import-from-apim command * feat: bump version to 1.0.0b5 and update changelog (#18) * build: fix ci (#22) * style: fix style warnings * test:fix test cases * fix: service update command failure (#28) * doc: fix command samples (#30) * doc: update changelog per feedback (#29) * doc: remove extra spaces in register command help message (#34) * doc: update api definition and metadata command samples (#36)
cegraybl
added a commit
to AzureCR/azure-cli-extensions
that referenced
this pull request
Sep 26, 2024
* add extension commands for support * update help text * minor improvements for new commands, I think the querying can be improved to avoid possible injection * fix query for task cancel and task status * mid commit: the log search and correlation seems to work, needs to be optimized, and tested * mid commit: added some optimization to make getting and matching logs faster, but I think it can be done better, one more try * more fixes, specially logic. Got the list to run in ~7 seconds, down from 60 * simplify some structures, change the behaviour of the logs, general fixes and improvements * rename command 'track-status' to 'list' and update help texts * add missing refactor for the list command * fix issues that would block logs from being downloaded, simplify a bit of the workflow status * fix listing status for the patched images * remove unnecessary parameter from generate_logs * add a 'Running' progress bar to listing task status, add a duration debug message * add filtering to listing, and add a 'running' progress * use task constants for filtering during cancel * modify the output to exemplify a bit a undefined situation, try to fix the progress tracker * fix issue during 'list' where the 'enabled' field is marked as required in the config schema * raise the validation errors on the config schema * update help text for the json config schema * fix lint and style issues * fix bug when displaying output for dry-run * add new state for patching (skipped) and add an optional output for the 'list' command showing the reason to skip patching * improvements based on phase 1.5 PRD update * fix inconsistency on tags between incremental and floating conventions * fix corner case on patched images with incremental, and failed tasks --------- Co-authored-by: pwalecha <67886536+pwalecha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.