Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AuthV2] Address Bug Bash feedback #3782

Merged
merged 12 commits into from
Aug 30, 2021
Merged

[AuthV2] Address Bug Bash feedback #3782

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
035dd97
first lot of feedback
mkarmark Aug 17, 2021
43699e8
get tests to pass
mkarmark Aug 17, 2021
71c4a3c
fix static analysis errors
mkarmark Aug 17, 2021
833da57
remaining fixes
mkarmark Aug 17, 2021
8c934d2
fix static analysis errors
mkarmark Aug 17, 2021
bb74aca
address pr comments
mkarmark Aug 20, 2021
c2c570c
add comment
mkarmark Aug 20, 2021
e8c8e93
try to pass static analysis
mkarmark Aug 20, 2021
bae77a4
make all settings slot sticky
mkarmark Aug 20, 2021
547de53
done
mkarmark Aug 23, 2021
7a33e01
Address Sisira's comments
mkarmark Aug 27, 2021
fd40d25
Update custom.py
mkarmark Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/authV2/azext_authV2/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@
get_three_state_flag, get_enum_type)
from azure.cli.command_modules.appservice._params import AUTH_TYPES
from azure.cli.core.local_context import LocalContextAttribute, LocalContextAction
from azure.cli.core.cloud import AZURE_PUBLIC_CLOUD, AZURE_CHINA_CLOUD, AZURE_US_GOV_CLOUD, AZURE_GERMAN_CLOUD

UNAUTHENTICATED_CLIENT_ACTION = ['RedirectToLoginPage', 'AllowAnonymous', 'RejectWith401', 'RejectWith404']
FORWARD_PROXY_CONVENTION = ['NoProxy', 'Standard', 'Custom']
CLOUD_NAMES = [AZURE_PUBLIC_CLOUD.name, AZURE_CHINA_CLOUD.name, AZURE_US_GOV_CLOUD.name, AZURE_GERMAN_CLOUD.name]


def load_arguments(self, _):
Expand Down Expand Up @@ -76,6 +78,10 @@ def load_arguments(self, _):
c.argument('allowed_token_audiences', options_list=['--allowed-token-audiences', '--allowed-audiences'],
help='The configuration settings of the allowed list of audiences from which to validate the JWT token.')
c.argument('yes', options_list=['--yes', '-y'], help='Do not prompt for confirmation.', action='store_true')
c.argument('tenant_id', options_list=['--tenant-id'],
help='The tenant id of the application.')
c.argument('cloud', options_list=['--cloud'], arg_type=get_enum_type(CLOUD_NAMES),
mkarmark marked this conversation as resolved.
Show resolved Hide resolved
help='The name of the cloud that the application belongs to.')

with self.argument_context('webapp auth facebook update') as c:
c.argument('app_id', options_list=['--app-id'],
Expand Down Expand Up @@ -149,6 +155,9 @@ def load_arguments(self, _):
help='The endpoint that contains all the configuration endpoints for the provider.')
c.argument('scopes', options_list=['--scopes'],
help='A list of the scopes that should be requested while authenticating.')
c.argument('client_secret', options_list=['--client-secret'],
help='The application secret of the app used for login.')
c.argument('yes', options_list=['--yes', '-y'], help='Do not prompt for confirmation.', action='store_true')

with self.argument_context('webapp auth openid-connect update') as c:
c.argument('provider_name', options_list=['--provider-name'], required=True,
Expand All @@ -161,6 +170,9 @@ def load_arguments(self, _):
help='The endpoint that contains all the configuration endpoints for the provider.')
c.argument('scopes', options_list=['--scopes'],
help='A list of the scopes that should be requested while authenticating.')
c.argument('client_secret', options_list=['--client-secret'],
help='The application secret of the app used for login.')
c.argument('yes', options_list=['--yes', '-y'], help='Do not prompt for confirmation.', action='store_true')

with self.argument_context('webapp auth openid-connect remove') as c:
c.argument('provider_name', options_list=['--provider-name'], required=True,
Expand Down
Loading