Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AuthV2] Address Bug Bash feedback #3782

Merged
merged 12 commits into from
Aug 30, 2021
Merged

[AuthV2] Address Bug Bash feedback #3782

merged 12 commits into from
Aug 30, 2021

Commits on Aug 17, 2021

  1. first lot of feedback

    @mkarmark
    mkarmark committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    035dd97 View commit details
    Browse the repository at this point in the history

  2. get tests to pass

    @mkarmark
    mkarmark committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    43699e8 View commit details
    Browse the repository at this point in the history

  3. fix static analysis errors

    @mkarmark
    mkarmark committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    71c4a3c View commit details
    Browse the repository at this point in the history

  4. remaining fixes

    @mkarmark
    mkarmark committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    833da57 View commit details
    Browse the repository at this point in the history

  5. fix static analysis errors

    @mkarmark
    mkarmark committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    8c934d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. address pr comments

    @mkarmark
    mkarmark committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    bb74aca View commit details
    Browse the repository at this point in the history

  2. add comment

    @mkarmark
    mkarmark committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    c2c570c View commit details
    Browse the repository at this point in the history

  3. try to pass static analysis

    @mkarmark
    mkarmark committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    e8c8e93 View commit details
    Browse the repository at this point in the history

  4. make all settings slot sticky

    @mkarmark
    mkarmark committed Aug 20, 2021
    Configuration menu
    Copy the full SHA
    bae77a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. done

    @mkarmark
    mkarmark committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    547de53 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Address Sisira's comments

    @mkarmark
    mkarmark committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    7a33e01 View commit details
    Browse the repository at this point in the history

  2. Update custom.py

    @mkarmark
    mkarmark authored Aug 27, 2021
    Configuration menu
    Copy the full SHA
    fd40d25 View commit details
    Browse the repository at this point in the history