Description
openedon Apr 6, 2022
Feature request
Background
For Spring-cloud extension, we released 3.1.0
including introduce new SDK for 2022-03-01-preview apiVersion. However, this sdk imports a library available in Azure CLI Core from version 2.30.0
, however, the azext.minCliCoreVersion
for 3.1.0
is 2.25.0
. Customer who uses Azure CLI among [2.25.0
, 2.30.0
) will failed all commands for spring-cloud
extension 3.1.0
.
Related PR
- Vendor AppPlatform 2022-03-01-preview SDK
- Add support for AppMSI
- Upgrade min version requirement of azure cli for spring-cloud
- [Spring-cloud] Find min version requirement of Azure CLI #4626
Request
In the pull request of an extension, run the CI with at least 2 Azure CLI version:
- Version specified in "azext.minCliCoreVersion" for an extension.
- latest
Known issue
In src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage
, there is an annotation @StorageAccountPreparer()
, when running the test, with azure-cli 2.34.1
, it's calling to storage account with apiVersion 2020-08-01
, where older azure-cli is using 2020-06-01
, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.
class ByosTest(ScenarioTest):
@ResourceGroupPreparer()
@StorageAccountPreparer()
def test_persistent_storage(self, resource_group, storage_account):
template = 'storage account keys list -n {} -g {} --query "[0].value" -otsv'
accountkey = self.cmd(template.format(storage_account, resource_group)).output