Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring-cloud] Upgrade min version requirement of azure cli for spring-cloud #4621

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

jiec-msft
Copy link
Contributor

@jiec-msft jiec-msft commented Apr 2, 2022


What does this PR do?

  1. We released spring-cloud CLI extension 3.1.0 with below PRs:
  2. Later we find this CLI extension is not compatible with Azure CLI version 2.26.0, the error is "No module named 'azure.core.rest'", see below screenshot.
    • image
  3. Impact: all customers use old version of CLI and spring-cloud cli extension 3.1.0 will be failed to execute any spring-cloud commands.
  4. Based on that most of the testing spring-cloud extension 3.1.0 is carried out with CLI 2.34.1, we update minimal requirement for azure-cli from 2.25.0 to 2.34.1 to quick mitigate this problem.
  5. Release a new version of CLI 3.1.1 as fix.

Follow ups

  1. Verify the suitable min version of azure cli.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost added Spring Cloud Spring Cloud related issues Auto-Assign Auto assign by bot labels Apr 2, 2022
@ghost ghost requested review from zhoxing-ms, wangzelin007 and yonzhan April 2, 2022 08:06
@ghost ghost assigned zhoxing-ms Apr 2, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Spring Cloud Spring Cloud related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants