fix(Templates): Update parameter blocked on error #7345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues blocking parameter saves on validation errors and updates related UI text/content across workflows and template configuration panels.
- Refactors save-button disabling logic in parameter customization to no longer block on error states
- Updates workflow display name hint/description and panel header copy
- Cleans up localization keys and adjusts local test configuration values
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/designer/src/lib/ui/configuretemplate/workflows/customizeWorkflows.tsx | Replaced hint text and added description for workflow display name |
| libs/designer/src/lib/ui/configuretemplate/panels/customizeParameterPanel/customizeParameterPanel.tsx | Removed error-based disabling for Save button and updated hook dependencies |
| libs/designer/src/lib/ui/configuretemplate/panels/configureWorkflowsPanel/configureWorkflowsPanel.tsx | Simplified header title logic and inlined the panel title string |
| apps/Standalone/src/configuretemplate/app/LocalConfigureTemplate.tsx | Updated hard-coded testTemplateId and defaultLocation values |
| Localize/lang/strings.json | Added new localization entries and removed obsolete keys |
Comments suppressed due to low confidence (1)
libs/designer/src/lib/ui/configuretemplate/panels/customizeParameterPanel/customizeParameterPanel.tsx:85
- Add or update unit tests to cover the new disabling logic: ensure the Save button remains enabled when a
parameterErroris present since that condition was removed.
disabled: !isDirty || isDisplayNameEmpty,
...gner/src/lib/ui/configuretemplate/panels/customizeParameterPanel/customizeParameterPanel.tsx
Show resolved
Hide resolved
apps/Standalone/src/configuretemplate/app/LocalConfigureTemplate.tsx
Outdated
Show resolved
Hide resolved
preetriti1
reviewed
May 28, 2025
libs/designer/src/lib/ui/configuretemplate/workflows/customizeWorkflows.tsx
Show resolved
Hide resolved
preetriti1
approved these changes
May 28, 2025
Elaina-Lee
added a commit
that referenced
this pull request
May 28, 2025
* fixed disabling parameter value update when errors exist in state * renamed display name explanations * renamed workflows panel title * changed worklfow name and display name props * fixed breaking & changed description
3 tasks
Elaina-Lee
added a commit
that referenced
this pull request
May 28, 2025
* fix(templates): Fixing content updates in configure workflows panel (#7349) * fix(Templates): Updating hotfix branch with three fixes (#7301) * fix(templates): Adding info bubble support and text for workflow customization wizard (#7297) * feat(templates): Adding created and last modified column in workflows and toaster * fix(templates): Updating info text needed in wizard form --------- Co-authored-by: Priti Sambandam <psamband@microsoft.com> * fix(Templates): UI fixes to enforce consistency & Remove placeholder links (#7291) * chnaged paramters name, displayName order & made name clickable * removed workflow identifier from display view * added aeritesk for required for publish fields * added links for redirects * added hints for display names & disabled save when not present * changed links & fixed scrollbar * added for publish for validation error messages * fixed tests * fix(Templates): Fixed connection name and type not showing up in review tab (#7300) Fixed connection name and type not showing up in review tab --------- Co-authored-by: preetriti1 <48265693+preetriti1@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> * chore(release): 5.109.1 * fix(designer): Update open AI endpoint for foundry connections (#7307) fix(designer): Update open AI endpoint for foundry connections (#7306) * Update open ai endpoint for foundry connections * Revert Localize * Update endpoint string * Revert Localize * Fix typo * Rever Localize * fix(Designer): Variable/Hybrid Cherry picks (#7325) * fix(designer): Agents in Hybrid not working (#7303) * quick fix * fix hybrid agent fetch * fix(designer): Fix Variable Editor Causing Issues on Strings (#7302) * quick fix * my brain hurts * fix changes * fix test * is it working? * add logic to agent params and created tests * fix test * update code * Revert "update code" This reverts commit 7669b64. * fix(templates): Fixing content updates in configure workflows panel --------- Co-authored-by: Elaina Lee <144840522+Elaina-Lee@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> Co-authored-by: release-automation-Elaina-Lee@microsoft.com <Elaina-Lee> Co-authored-by: Carlos Emiliano Castro Trejo <102700317+ccastrotrejo@users.noreply.github.com> Co-authored-by: Eric Wu <95886809+Eric-B-Wu@users.noreply.github.com> * fix(Templates): Popup delete modal for workflows & disable on non-selected (#7346) * fixed delete not being disabled on nothing selected * added modal and fixed delete button still consisting prev selectedWorkflow logic * added back description link * fix(Templates): Select all for workflows table not working (#7347) * enabled select all for workflows tab * fixed selection on workflow panel * moved select all to checkbox only * fix(Templates): Update parameter blocked on error (#7345) * fixed disabling parameter value update when errors exist in state * renamed display name explanations * renamed workflows panel title * changed worklfow name and display name props * fixed breaking & changed description --------- Co-authored-by: preetriti1 <48265693+preetriti1@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> Co-authored-by: Carlos Emiliano Castro Trejo <102700317+ccastrotrejo@users.noreply.github.com> Co-authored-by: Eric Wu <95886809+Eric-B-Wu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Fixes
Fixes [Custom Templates] Updating parameters not working #7343, [Custom templates] Workflow tab: Text update for workflow name helper text #7335, [Custom templates] Workflow tab: Text update for side panel #7338