fix(designer): Fix Variable Editor Causing Issues on Strings #7302

Eric-B-Wu · 2025-05-23T03:38:41Z

Fixed an issue where new lines didn't work on strings in variable editor:
#7259
Fixed an issue where escape characters were failing to parse in string type of variable editor:
[Internal ICM]: https://portal.microsofticm.com/imp/v5/incidents/details/632168505/summary
Fixed an issue where sometimes tokens would not be able to be retrieved and would load as a string

takyyon · 2025-05-23T14:18:26Z

libs/designer-ui/src/lib/editor/initializevariable/util.ts


-export const parseVariableEditorSegments = (initialValue: ValueSegment[]): InitializeVariableProps[] | undefined => {
+  // 3. Otherwise, fall back to the longer one (typically more structured or complete)
+  if ((fromConvert?.length || 0) > (fromHandler?.length || 0)) {


Suggested change

if ((fromConvert?.length || 0) > (fromHandler?.length || 0)) {

if ((fromConvert?.length ?? 0) > (fromHandler?.length ?? 0)) {

This is comparing lengths, so we'll want to use || to ensure its always a number and not false or ''

Exactly, with || it essentially creates a boolean no? "??" is to mark a default value if the first one is undefined

libs/designer-ui/src/lib/editor/initializevariable/util.ts

takyyon

A couple of changes please

…/variableFixes

libs/designer-ui/src/lib/editor/initializevariable/util.ts

libs/logic-apps-shared/src/utils/src/lib/helpers/stringFunctions.ts

This reverts commit 7669b64.

* quick fix * my brain hurts * fix changes * fix test * is it working? * add logic to agent params and created tests * fix test * update code * Revert "update code" This reverts commit 7669b64.

* fix(designer): Agents in Hybrid not working (#7303) * quick fix * fix hybrid agent fetch * fix(designer): Fix Variable Editor Causing Issues on Strings (#7302) * quick fix * my brain hurts * fix changes * fix test * is it working? * add logic to agent params and created tests * fix test * update code * Revert "update code" This reverts commit 7669b64.

* filtering fixes * :revert "fix(designer): Reset id replacements when reset designer dirty state (#7105)" This reverts commit fefe073. * revert part of pr * revert * fix(designer): Fix Variable Editor Causing Issues on Strings (#7302) * quick fix * my brain hurts * fix changes * fix test * is it working? * add logic to agent params and created tests * fix test * update code * Revert "update code" This reverts commit 7669b64.

…7349) * fix(Templates): Updating hotfix branch with three fixes (#7301) * fix(templates): Adding info bubble support and text for workflow customization wizard (#7297) * feat(templates): Adding created and last modified column in workflows and toaster * fix(templates): Updating info text needed in wizard form --------- Co-authored-by: Priti Sambandam <psamband@microsoft.com> * fix(Templates): UI fixes to enforce consistency & Remove placeholder links (#7291) * chnaged paramters name, displayName order & made name clickable * removed workflow identifier from display view * added aeritesk for required for publish fields * added links for redirects * added hints for display names & disabled save when not present * changed links & fixed scrollbar * added for publish for validation error messages * fixed tests * fix(Templates): Fixed connection name and type not showing up in review tab (#7300) Fixed connection name and type not showing up in review tab --------- Co-authored-by: preetriti1 <48265693+preetriti1@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> * chore(release): 5.109.1 * fix(designer): Update open AI endpoint for foundry connections (#7307) fix(designer): Update open AI endpoint for foundry connections (#7306) * Update open ai endpoint for foundry connections * Revert Localize * Update endpoint string * Revert Localize * Fix typo * Rever Localize * fix(Designer): Variable/Hybrid Cherry picks (#7325) * fix(designer): Agents in Hybrid not working (#7303) * quick fix * fix hybrid agent fetch * fix(designer): Fix Variable Editor Causing Issues on Strings (#7302) * quick fix * my brain hurts * fix changes * fix test * is it working? * add logic to agent params and created tests * fix test * update code * Revert "update code" This reverts commit 7669b64. * fix(templates): Fixing content updates in configure workflows panel --------- Co-authored-by: Elaina Lee <144840522+Elaina-Lee@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> Co-authored-by: release-automation-Elaina-Lee@microsoft.com <Elaina-Lee> Co-authored-by: Carlos Emiliano Castro Trejo <102700317+ccastrotrejo@users.noreply.github.com> Co-authored-by: Eric Wu <95886809+Eric-B-Wu@users.noreply.github.com>

* fix(templates): Fixing content updates in configure workflows panel (#7349) * fix(Templates): Updating hotfix branch with three fixes (#7301) * fix(templates): Adding info bubble support and text for workflow customization wizard (#7297) * feat(templates): Adding created and last modified column in workflows and toaster * fix(templates): Updating info text needed in wizard form --------- Co-authored-by: Priti Sambandam <psamband@microsoft.com> * fix(Templates): UI fixes to enforce consistency & Remove placeholder links (#7291) * chnaged paramters name, displayName order & made name clickable * removed workflow identifier from display view * added aeritesk for required for publish fields * added links for redirects * added hints for display names & disabled save when not present * changed links & fixed scrollbar * added for publish for validation error messages * fixed tests * fix(Templates): Fixed connection name and type not showing up in review tab (#7300) Fixed connection name and type not showing up in review tab --------- Co-authored-by: preetriti1 <48265693+preetriti1@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> * chore(release): 5.109.1 * fix(designer): Update open AI endpoint for foundry connections (#7307) fix(designer): Update open AI endpoint for foundry connections (#7306) * Update open ai endpoint for foundry connections * Revert Localize * Update endpoint string * Revert Localize * Fix typo * Rever Localize * fix(Designer): Variable/Hybrid Cherry picks (#7325) * fix(designer): Agents in Hybrid not working (#7303) * quick fix * fix hybrid agent fetch * fix(designer): Fix Variable Editor Causing Issues on Strings (#7302) * quick fix * my brain hurts * fix changes * fix test * is it working? * add logic to agent params and created tests * fix test * update code * Revert "update code" This reverts commit 7669b64. * fix(templates): Fixing content updates in configure workflows panel --------- Co-authored-by: Elaina Lee <144840522+Elaina-Lee@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> Co-authored-by: release-automation-Elaina-Lee@microsoft.com <Elaina-Lee> Co-authored-by: Carlos Emiliano Castro Trejo <102700317+ccastrotrejo@users.noreply.github.com> Co-authored-by: Eric Wu <95886809+Eric-B-Wu@users.noreply.github.com> * fix(Templates): Popup delete modal for workflows & disable on non-selected (#7346) * fixed delete not being disabled on nothing selected * added modal and fixed delete button still consisting prev selectedWorkflow logic * added back description link * fix(Templates): Select all for workflows table not working (#7347) * enabled select all for workflows tab * fixed selection on workflow panel * moved select all to checkbox only * fix(Templates): Update parameter blocked on error (#7345) * fixed disabling parameter value update when errors exist in state * renamed display name explanations * renamed workflows panel title * changed worklfow name and display name props * fixed breaking & changed description --------- Co-authored-by: preetriti1 <48265693+preetriti1@users.noreply.github.com> Co-authored-by: Priti Sambandam <psamband@microsoft.com> Co-authored-by: Carlos Emiliano Castro Trejo <102700317+ccastrotrejo@users.noreply.github.com> Co-authored-by: Eric Wu <95886809+Eric-B-Wu@users.noreply.github.com>

Eric-B-Wu added 7 commits May 9, 2025 10:52

quick fix

f3f0abb

Merge branch 'main' of https://github.com/Azure/LogicAppsUX

ecf6e32

Merge branch 'main' of https://github.com/Azure/LogicAppsUX

4ec4d95

Merge branch 'main' of https://github.com/Azure/LogicAppsUX

7d91566

Merge branch 'main' of https://github.com/Azure/LogicAppsUX

6b0226c

Merge branch 'main' of https://github.com/Azure/LogicAppsUX

0ecf212

my brain hurts

fec611f

Eric-B-Wu added the risk:low Low risk change with minimal impact label May 23, 2025

takyyon approved these changes May 23, 2025

View reviewed changes

takyyon reviewed May 23, 2025

View reviewed changes

libs/designer-ui/src/lib/editor/initializevariable/util.ts Outdated Show resolved Hide resolved

takyyon requested changes May 23, 2025

View reviewed changes

Eric-B-Wu added 5 commits May 23, 2025 10:08

fix changes

d9b9779

fix test

7c5e0b0

is it working?

ae867be

add logic to agent params and created tests

96af14c

Merge branch 'main' of https://github.com/Azure/LogicAppsUX into eric…

7e6a269

…/variableFixes

github-advanced-security bot found potential problems May 24, 2025

View reviewed changes

libs/designer-ui/src/lib/editor/initializevariable/util.ts Dismissed Show dismissed Hide dismissed

libs/designer-ui/src/lib/editor/initializevariable/util.ts Dismissed Show dismissed Hide dismissed

fix test

13ccd62

takyyon approved these changes May 25, 2025

View reviewed changes

libs/logic-apps-shared/src/utils/src/lib/helpers/stringFunctions.ts Show resolved Hide resolved

libs/logic-apps-shared/src/utils/src/lib/helpers/stringFunctions.ts Show resolved Hide resolved

Eric-B-Wu added 2 commits May 25, 2025 12:59

update code

7669b64

Revert "update code"

fa92931

This reverts commit 7669b64.

takyyon approved these changes May 25, 2025

View reviewed changes

Eric-B-Wu merged commit 9670901 into main May 25, 2025
13 checks passed

Eric-B-Wu deleted the eric/variableFixes branch May 25, 2025 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(designer): Fix Variable Editor Causing Issues on Strings #7302

fix(designer): Fix Variable Editor Causing Issues on Strings #7302

Uh oh!

Eric-B-Wu commented May 23, 2025

Uh oh!

takyyon May 23, 2025

Uh oh!

Eric-B-Wu May 23, 2025

Uh oh!

takyyon May 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

takyyon left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	if ((fromConvert?.length \|\| 0) > (fromHandler?.length \|\| 0)) {
	if ((fromConvert?.length ?? 0) > (fromHandler?.length ?? 0)) {

fix(designer): Fix Variable Editor Causing Issues on Strings #7302

fix(designer): Fix Variable Editor Causing Issues on Strings #7302

Uh oh!

Conversation

Eric-B-Wu commented May 23, 2025

Uh oh!

takyyon May 23, 2025

Choose a reason for hiding this comment

Uh oh!

Eric-B-Wu May 23, 2025

Choose a reason for hiding this comment

Uh oh!

takyyon May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

takyyon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

takyyon May 23, 2025 •

edited

Loading