Skip to content

Recorded Future Identity - make boolean playbook parameters strings - #15268

Open
Niklas Logren (aommm) wants to merge 2 commits into
Azure:masterfrom
recordedfuture:rfpd-119053-identity-string-bools
Open

Niklas Logren (aommm) wants to merge 2 commits into
Azure:masterfrom
recordedfuture:rfpd-119053-identity-string-bools

Conversation

@aommm

@aommm Niklas Logren (aommm) commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Change(s)

  • Content Hub's "Create playbook" form doesn't show an input for ARM bool parameters. Deploying then fails with "Expected a value of type 'Boolean', but received a value of type 'String'".
  • This PR changes every bool deploy parameter in the Recorded Future Identity playbooks to string with allowedValues: ["true","false"]. Each default stays the same as before.
    • Parameters: confirm_user_as_risky, save_to_log_analytics_workspace, create_incident, create_role_assignment.
  • Wherever one of these is read, the template now uses bool(parameters(...)). That covers resource conditions and the values passed into Logic App Bool parameters, so the workflows behave exactly as before.
  • The same fix was requested by reviewers and applied in the Recorded Future solution PR Recorded Future: add owner_organisation_details columns #15138.
  • Solution version bumped to 3.2.1 and repackaged (3.2.1.zip, mainTemplate.json). Added a one-line release note.

Reason for Change(s)

  • Customers deploying from Content Hub can't set these parameters, and the deployment fails.

Version Updated

  • Yes. 3.2.1

Testing Completed

  • Repackaged with createSolutionV3.ps1; the JSON is valid.
  • ARM-TTK reports one failure, "IDs Should Be Derived From ResourceIDs". The same check also fails on the Recorded Future solution's code before its change in Recorded Future: add owner_organisation_details columns #15138; I haven't confirmed whether it already failed here.

This PR was AI generated (with human review).

…nt Hub deploy UI

Content Hub's playbook deployment form renders no input for bool ARM
parameters, causing 'Expected a value of type Boolean' deploy failures.
Use string parameters with allowedValues true/false and convert with
bool() where consumed. Bump solution to 3.2.1.

Refs: RFPD-119053
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Oct 6, 2026
@v-atulyadav
v-atulyadav requested a balanced review from Copilot October 6, 2026 10:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Content Hub deployment remains untested, and the reported ARM-TTK failure needs human triage.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Updates Recorded Future Identity playbooks to support boolean choices in Content Hub’s deployment form while preserving workflow behavior.

Changes:

  • Converts deployment flags to strings restricted to "true" and "false".
  • Converts values back to booleans at their usage points.
  • Bumps the solution to 3.2.1 and adds release notes.
File Description
Solutions/​Recorded Future Identity/​ReleaseNotes.md Documents the deployment fix.
Solutions/​Recorded Future Identity/​Playbooks/​v3.0/​RFI-search-workforce-user/​azuredeploy.json Converts the role-assignment flag.
Solutions/​Recorded Future Identity/​Playbooks/​v3.0/​RFI-search-external-user/​azuredeploy.json Converts the role-assignment flag.
Solutions/​Recorded Future Identity/​Playbooks/​v3.0/​RFI-lookup-and-save-user/​azuredeploy.json Converts the role-assignment flag.
Solutions/​Recorded Future Identity/​Playbooks/​RFI-Playbook-Alert-Importer/​azuredeploy.json Converts the risky-user flag.
Solutions/​Recorded Future Identity/​Playbooks/​RFI-Playbook-Alert-Importer-LAW/​azuredeploy.json Converts risk, logging, and role-assignment flags.
Solutions/​Recorded Future Identity/​Playbooks/​RFI-Playbook-Alert-Importer-LAW-Sentinel/​azuredeploy.json Converts risk, incident, and logging flags.
Solutions/​Recorded Future Identity/​Package/​mainTemplate.json Regenerated package; excluded from review.
Solutions/​Recorded Future Identity/​Data/​Solution_RecordedFutureIdentity.json Updates the solution version.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread Solutions/Recorded Future Identity/Data/Solution_RecordedFutureIdentity.json Outdated
@aommm Niklas Logren (aommm) changed the title RFPD-119053: Recorded Future Identity - make boolean playbook parameters strings Recorded Future Identity - make boolean playbook parameters strings Oct 6, 2026
@v-skharode

Copy link
Copy Markdown
Contributor

Hi Niklas Logren (@aommm)
set TemplateSpec to false for the 3.2.1 solution version. The ARM-TTK output showed one failure, but it was reported as pre-existing; GitHub’s checks were green.

@aommm

Copy link
Copy Markdown
Contributor Author

Fixed v-skharode , please check again

@aommm
Niklas Logren (aommm) marked this pull request as ready for review October 12, 2026 12:54
@aommm
Niklas Logren (aommm) requested review from a team as code owners October 12, 2026 12:54
@v-skharode

Copy link
Copy Markdown
Contributor

Thanks for the update. I’ll re-review the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Solution Solution specialty review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants