Repository navigation
Recorded Future Identity - make boolean playbook parameters strings - #15268
Open
Niklas Logren (aommm) wants to merge 2 commits into
Open
Niklas Logren (aommm) wants to merge 2 commits into
Niklas Logren (aommm) wants to merge 2 commits into
Conversation
…nt Hub deploy UI Content Hub's playbook deployment form renders no input for bool ARM parameters, causing 'Expected a value of type Boolean' deploy failures. Use string parameters with allowedValues true/false and convert with bool() where consumed. Bump solution to 3.2.1. Refs: RFPD-119053
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Content Hub deployment remains untested, and the reported ARM-TTK failure needs human triage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates Recorded Future Identity playbooks to support boolean choices in Content Hub’s deployment form while preserving workflow behavior.
Changes:
- Converts deployment flags to strings restricted to
"true"and"false". - Converts values back to booleans at their usage points.
- Bumps the solution to 3.2.1 and adds release notes.
| File | Description |
|---|---|
| Solutions/Recorded Future Identity/ReleaseNotes.md | Documents the deployment fix. |
| Solutions/Recorded Future Identity/Playbooks/v3.0/RFI-search-workforce-user/azuredeploy.json | Converts the role-assignment flag. |
| Solutions/Recorded Future Identity/Playbooks/v3.0/RFI-search-external-user/azuredeploy.json | Converts the role-assignment flag. |
| Solutions/Recorded Future Identity/Playbooks/v3.0/RFI-lookup-and-save-user/azuredeploy.json | Converts the role-assignment flag. |
| Solutions/Recorded Future Identity/Playbooks/RFI-Playbook-Alert-Importer/azuredeploy.json | Converts the risky-user flag. |
| Solutions/Recorded Future Identity/Playbooks/RFI-Playbook-Alert-Importer-LAW/azuredeploy.json | Converts risk, logging, and role-assignment flags. |
| Solutions/Recorded Future Identity/Playbooks/RFI-Playbook-Alert-Importer-LAW-Sentinel/azuredeploy.json | Converts risk, incident, and logging flags. |
| Solutions/Recorded Future Identity/Package/mainTemplate.json | Regenerated package; excluded from review. |
| Solutions/Recorded Future Identity/Data/Solution_RecordedFutureIdentity.json | Updates the solution version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Hi Niklas Logren (@aommm) |
Contributor
Author
|
Fixed v-skharode , please check again |
Niklas Logren (aommm)
marked this pull request as ready for review
October 12, 2026 12:54
Contributor
|
Thanks for the update. I’ll re-review the latest changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change(s)
boolparameters. Deploying then fails with "Expected a value of type 'Boolean', but received a value of type 'String'".booldeploy parameter in the Recorded Future Identity playbooks tostringwithallowedValues: ["true","false"]. Each default stays the same as before.confirm_user_as_risky,save_to_log_analytics_workspace,create_incident,create_role_assignment.bool(parameters(...)). That covers resource conditions and the values passed into Logic AppBoolparameters, so the workflows behave exactly as before.3.2.1.zip,mainTemplate.json). Added a one-line release note.Reason for Change(s)
Version Updated
Testing Completed
createSolutionV3.ps1; the JSON is valid.This PR was AI generated (with human review).