Repository navigation
Recorded Future: add owner_organisation_details columns - #15138
Conversation
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Pull request overview
Adds owner_organisation_details ingestion and storage support for Recorded Future alerts, updating templates and documentation so the new ownership info is persisted in Log Analytics and exposed to users.
Changes:
- Added new dynamic columns to LAW tables / DCR transforms for classic and playbook alerts.
- Updated both Logic App playbooks to include the new ownership field in payloads.
- Updated release notes and connector documentation to describe the manual upgrade requirement.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/Recorded Future/ReleaseNotes.md | Documents the new column(s) and manual redeploy requirement. |
| Solutions/Recorded Future/Playbooks/Alerts/RecordedFuture-Playbook-Alert-Importer/azuredeploy.json | Adds playbook alert payload field + release note entry. |
| Solutions/Recorded Future/Playbooks/Alerts/RecordedFuture-Alert-Importer/azuredeploy.json | Adds classic alert payload field + release note entry. |
| Solutions/Recorded Future/Package/mainTemplate.json | Updates packaged template content (including playbooks) to carry the new field; also includes reordering edits. |
| Solutions/Recorded Future/Data Connectors/azuredeploy.json | Adds LAW table columns + DCR transformKql projection for new field; bumps metadata. |
| Solutions/Recorded Future/Data Connectors/README.md | Adds “Upgrading” guidance about manual redeploy and where to check changes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Hi Niklas Logren (@aommm), |
…column names in release notes Addresses Copilot CR feedback on PR Azure#15138: the release note previously implied both tables use the snake_case column name, but the classic alerts table uses OwnerOrganisationDetails (PascalCase) while the playbook alerts table uses owner_organisation_details (snake_case).
|
v-rusraut done! |
|
Hi Niklas Logren (@aommm), Please also verify the solution package version. It is 3.2.22, while the release notes mention 3.2.23. Please update it accordingly |
|
Hi Niklas Logren (@aommm), Package version 3.2.22 has successfully cleared certification. You can now proceed with packaging the next version 3.2.23. please package it and commit changes. |
|
Hi Niklas Logren (@aommm) |
RFPD-113845: surface enterprise/organisation ownership info (owner_organisation_details) for both classic and playbook alerts in the Recorded Future Sentinel solution. - Add OwnerOrganisationDetails (classic) / owner_organisation_details (playbook) dynamic columns to the DCR streamDeclarations and workspace table schemas in Data Connectors/azuredeploy.json. - Map the new field in RecordedFuture-Alert-Importer's Compose_Record from owner_organisation_details on the triggered alert. - Map the new field in RecordedFuture-Playbook-Alert-Importer's Compose_Record from the playbook alert lookup response (requires bfi-azure >= 1.9.0). - Bump solution version to 3.2.23 in ReleaseNotes.md and each importer's metadata.releaseNotes. Tested end-to-end in the RF-Erik environment: verified via KQL that both RecordedFutureClassicAlerts_V2_CL and RecordedFuturePlaybookAlerts_V2_CL now populate the new column with real data from the Recorded Future Alerts API.
…column names in release notes Addresses Copilot CR feedback on PR Azure#15138: the release note previously implied both tables use the snake_case column name, but the classic alerts table uses OwnerOrganisationDetails (PascalCase) while the playbook alerts table uses owner_organisation_details (snake_case).
4d30519 to
2313eba
Compare
- Solutions/Recorded Future/Package/3.2.22.zip was accidentally overwritten by a repackage commit in this branch; restored from upstream/master since 3.2.22 has already cleared certification. - Bumped Data/Solution_RecordedFuture.json Version to 3.2.23 to match ReleaseNotes.md. - Shortened the 3.2.23 release note entry per reviewer feedback.
|
During the review, it was found that the Deploy to Azure Gov button in the readme.md files under the Playbooks contain a broken link. Please check all Playbook readme.md files for the Deploy to Azure Gov button and replace the existing broken link with the correct one: Old link: New link: After updating these links, there is no need to repackage the solution, as the changes are limited to the readme.md files. |
… API migration Adds troubleshooting guidance for the 'authentication token provided does not have access to ingest data' error seen on the six playbooks migrated to the Log Ingestion API. Root-caused as an expected RBAC propagation race (Monitoring Metrics Publisher on the DCR can take up to ~30 min to propagate) rather than a misconfiguration - confirmed by reproducing the failure on a fresh deployment and observing it self-heal on retry with no changes. Also clarifies: - the Roles and Permissions table describes deployer permissions, not the playbook's own managed identity permissions
bbf1607 to
403dc59
Compare
|
Hi Niklas Logren (@aommm), |
…the playbook deploy UI The Sentinel content hub playbook deployment UI renders no input for bool parameters. Use a string with allowedValues true/false and compare via equals(toLower(...), 'true'). Repackage 3.2.23.
|
Hi v-rusraut , I've pushed a fix now. I deployed the templates individually (from buttons in Github readme). We don't know any way of testing the full "content hub flow" other than deploying it to prod, updating our solution in content hub and testing there. If there's a better way we would be happy to hear it! |
|
Hi Niklas Logren (@aommm) Document : |
|
Hi Niklas Logren (@aommm), |








Change(s):
owner_organisation_detailscolumns to two LAW tables, DCE/DCR definitions, and to the Logic Apps that perform ingestionVersion updated:
Testing Completed: