Add variant allocation and flag telemetry information to request tracing #540
Conversation
...ns.Configuration.AzureAppConfiguration/FeatureManagement/FeatureManagementKeyValueAdapter.cs
Show resolved
Hide resolved
...osoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureFlagTracing.cs
Outdated
Show resolved
Hide resolved
| return UsesSeed || UsesTelemetry || UsesVariantConfigurationReference; | ||
| } | ||
|
|
||
| public void ResetFeatureFlagTracing() |
There was a problem hiding this comment.
You need to reset maxvariants right? And what about uses telemetry and uses variant configuration reference?
…otnetProvider into ajusupovic/emit-variants-telemetry
| public const string FeatureFlagUsesSeedTag = "FFSeed"; | ||
| public const string FeatureFlagMaxVariantsKey = "MaxVariants"; | ||
| public const string FeatureFlagUsesVariantConfigurationReferenceTag = "FFConfigRef"; | ||
| public const string FeaturesKey = "Features"; |
There was a problem hiding this comment.
Do we want to scope this to feature flags only? If so, it probably makes more sense to have "FFFeatures". On the other hand, we could drop the FF from others, so we will have, for example, FFFeatures=Seed+Telemetry+ConfigRef.
There was a problem hiding this comment.
It sounds reasonable to me. But that also means we have non-feature flag related items we would have Features= and FFFeatures=
There was a problem hiding this comment.
Since we don't currently have anything to under Features=, should I just add the constant but not use it yet or is there something we want to move into this section?
There was a problem hiding this comment.
We're not using Features= at the moment. There's no reason to have it.
...icrosoft.Extensions.Configuration.AzureAppConfiguration/Constants/RequestTracingConstants.cs
Show resolved
Hide resolved
...osoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureFlagTracing.cs
Outdated
Show resolved
Hide resolved
...ns.Configuration.AzureAppConfiguration/FeatureManagement/FeatureManagementKeyValueAdapter.cs
Outdated
Show resolved
Hide resolved
…eatureManagement/FeatureManagementKeyValueAdapter.cs Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com>
Summary
This PR aims to add information about the newest feature flag properties to request tracing. The feature flag properties include variants, allocation, and telemetry.
Design
Currently, the following information will be added to request tracing: