Add failover & load balancing telemetry #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiyuanliang-ms
requested review from
RichardChen820,
amerjusupovic,
avanigupta and
jimmyca15
Closed
zhiyuanliang-ms
changed the title
jimmyca15
reviewed
Aug 9, 2024
...icrosoft.Extensions.Configuration.AzureAppConfiguration/Constants/RequestTracingConstants.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Show resolved
Hide resolved
Member
|
LGTM |
RichardChen820
approved these changes
Aug 13, 2024
avanigupta
reviewed
Aug 14, 2024
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/RequestTracingOptions.cs
Show resolved
Hide resolved
avanigupta
reviewed
Aug 14, 2024
...icrosoft.Extensions.Configuration.AzureAppConfiguration/Constants/RequestTracingConstants.cs
Outdated
Show resolved
Hide resolved
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/failover-telemetry
branch
from
69d27d6 to
fada45a
Compare
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/failover-telemetry
branch
from
fada45a to
7a5fcfa
Compare
zhiyuanliang-ms
force-pushed
the
zhiyuanliang/failover-telemetry
branch
from
2cb2e34 to
d730fd6
Compare
avanigupta
approved these changes
Aug 15, 2024
...osoft.Extensions.Configuration.AzureAppConfiguration/FeatureManagement/FeatureFlagTracing.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this PR?
#583
We want to know these things.
Replica auto discovery is enabled by default. So we don't track it.
The request type (startup/refresh) is already added to the request tracing. So as long as we add tag for the request if it is a failover request, we can tell whether it saved startup or refresh operation.
Visible change
Correlation context will have two more tags:
UsesLoadBalancingandFailoverRequest